Uh oh!
There was an error while loading. Please reload this page.
fix Miri offset_from - #66083
Conversation
rust-highfive
commented
Nov 4, 2019
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
RalfJung
commented
Nov 4, 2019
This PR fixes https://github.com/RalfJung/miri-test-libstd, which currently fails. |
RalfJung
commented
Nov 5, 2019
r? @oli-obk |
| let b = self.read_immediate(args[1])?.to_scalar()?; | ||
| // Special case: if both scalars are *equal integers* | ||
| // and not NULL, their offset is 0. |
There was a problem hiding this comment.
why is the null case important? The docs state nothing of the kind. Or is the "valid object" thing the problem?
There was a problem hiding this comment.
Actually, since wrapping_offset_from is safe, and you can supply null pointers to it... I guess this should be allowed?
There was a problem hiding this comment.
Indeed this is about the "valid object" part. There's never a valid object at 0, not even one of size 0, so 0 is never a valid input here.
wrapping_offset_from does not have the "valid object" requirement.
RalfJung
commented
Nov 5, 2019
@bors r=oli-obk p=1 |
bors
commented
Nov 5, 2019
📌 Commit a593b54 has been approved by |
bors
commented
Nov 5, 2019
fix Miri offset_from This is needed to make rust-lang/miri#1032 pass.
bors
commented
Nov 5, 2019
☀️ Test successful - checks-azure |
test offset_from This currently fails and needs a rustc fix: rust-lang/rust#66083
This is needed to make rust-lang/miri#1032 pass.