Uh oh!
There was an error while loading. Please reload this page.
Tweak type mismatch caused by break on tail expr - #66101
Merged
Merged
Conversation
rust-highfive
commented
Nov 5, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Centril
reviewed
Nov 5, 2019
Centril
left a comment
Contributor
There was a problem hiding this comment.
r=me with comment addressed in some fashion.
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Nov 5, 2019
Contributor
r? @Centril |
When `break;` has a type mismatch because the `Destination` points at a tail expression with an obligation flowing from a return type, point at the return type. Fixrust-lang#39968.
estebankforce-pushed
the
break-tail-e0308
branch
from
November 5, 2019 22:50
16bb1b1 to
b0f258bCompareestebank
commented
Nov 5, 2019
ContributorAuthor
@bors r=Centril |
bors
commented
Nov 5, 2019
Collaborator
📌 Commit b0f258b has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Nov 5, 2019
Tweak type mismatch caused by break on tail expr When `break;` has a type mismatch because the `Destination` points at a tail expression with an obligation flowing from a return type, point at the return type. Fixrust-lang#39968.
Centril added a commit
to Centril/rust
that referenced
this pull request
Nov 6, 2019
Tweak type mismatch caused by break on tail expr When `break;` has a type mismatch because the `Destination` points at a tail expression with an obligation flowing from a return type, point at the return type. Fixrust-lang#39968.
bors added a commit
that referenced
this pull request
Nov 6, 2019
Rollup of 11 pull requests Successful merges: - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.) - #66014 (Show type parameter name and definition in type mismatch error messages ) - #66027 (Move has_panic_handler to query) - #66054 (syntax: Avoid span arithmetic for delimiter tokens) - #66068 (use silent emitter for rustdoc highlighting pass) - #66081 (let caller of check_ptr_access_align control the error message) - #66093 (Do not ICE with a precision flag in formatting str and no format arguments) - #66098 (Detect `::` -> `:` typo when involving turbofish) - #66101 (Tweak type mismatch caused by break on tail expr) - #66106 (Fix typo in explanation of `E0080`) - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
break;has a type mismatch because theDestinationpoints at a tailexpression with an obligation flowing from a return type, point at the
return type.
Fix#39968.