Uh oh!
There was an error while loading. Please reload this page.
Make error and warning annotations mandatory in UI tests - #66213
Conversation
rust-highfive
commented
Nov 8, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
tmiasko
commented
Nov 8, 2019
rust-highfive
commented
Nov 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
04519ce to
3b3600aComparerust-highfive
commented
Nov 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
dc6118c to
d989031CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d989031 to
5d28b23Comparetmiasko
commented
Nov 9, 2019
Rebased and amended commits with suggestions. |
petrochenkov
commented
Nov 10, 2019
Thanks! |
bors
commented
Nov 10, 2019
📌 Commit 5d28b23b51054a4aae39f82bcc8b0bb38deaddcf has been approved by |
bors
commented
Nov 10, 2019
☔ The latest upstream changes (presumably #66070) made this pull request unmergeable. Please resolve the merge conflicts. |
This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
5d28b23 to
427952eComparetmiasko
commented
Nov 10, 2019
Rebased. |
petrochenkov
commented
Nov 11, 2019
@bors r+ |
bors
commented
Nov 11, 2019
📌 Commit 427952e has been approved by |
bors
commented
Nov 11, 2019
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations. Fixes#55596.
bors
commented
Nov 11, 2019
☀️ Test successful - checks-azure |
This change makes error and warning annotations mandatory in UI tests.
The only exception are tests that use error patterns to match compiler
output and don't have any annotations.
Fixes#55596.