Skip to content

Add some tests for fixed ICEs - #66331

Merged
bors merged 4 commits into
rust-lang:masterfrom
JohnTitor:add-tests
Nov 13, 2019
Merged

Add some tests for fixed ICEs#66331
bors merged 4 commits into
rust-lang:masterfrom
JohnTitor:add-tests

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Closes#30904 (fixed between nightly-2019-07-14 and nightly-2019-07-31)
Closes#40231 (example 1 is fixed in 1.32.0, example 2 is fixed in 1.38.0)
Closes#52432 (fixed in rustc 1.40.0-beta.1 (76b4053 2019-11-05))
Closes#63279 (fixed in rustc 1.40.0-nightly (246be7e 2019-10-25))

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2019
@CentrilCentril added F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` F-unboxed_closures `#![feature(unboxed_closures)]` labels Nov 12, 2019
@Centril

Copy link
Copy Markdown
Contributor

r=me when green

@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 74d45af has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 13, 2019
Add some tests for fixed ICEs
Closesrust-lang#30904 (fixed between nightly-2019-07-14 and nightly-2019-07-31)
Closesrust-lang#40231 (example 1 is fixed in 1.32.0, example 2 is fixed in 1.38.0)
Closesrust-lang#52432 (fixed in rustc 1.40.0-beta.1 (76b4053 2019-11-05))
Closesrust-lang#63279 (fixed in rustc 1.40.0-nightly (246be7e 2019-10-25))
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 13, 2019
bors added a commit that referenced this pull request Nov 13, 2019
Rollup of 13 pull requests
Successful merges:
- #65932 (download .tar.xz if python3 is used)
- #66074 ([mir-opt] Turn on the `ConstProp` pass by default)
- #66094 (Fix documentation for `Iterator::count()`.)
- #66166 (rename cfg(rustdoc) into cfg(doc))
- #66227 (docs: Fix link to BufWriter::flush)
- #66292 (add Result::map_or)
- #66297 (Add a callback that allows compiler consumers to override queries.)
- #66317 (Use a relative bindir for rustdoc to find rustc)
- #66330 (Improve non-exhaustiveness handling in usefulness checking)
- #66331 (Add some tests for fixed ICEs)
- #66334 (Move Session fields to CrateStore)
- #66335 (Move self-profile infrastructure to data structures)
- #66337 (Remove dead code for encoding/decoding lint IDs)
Failed merges:
r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 13, 2019
Add some tests for fixed ICEs
Closesrust-lang#30904 (fixed between nightly-2019-07-14 and nightly-2019-07-31)
Closesrust-lang#40231 (example 1 is fixed in 1.32.0, example 2 is fixed in 1.38.0)
Closesrust-lang#52432 (fixed in rustc 1.40.0-beta.1 (76b4053 2019-11-05))
Closesrust-lang#63279 (fixed in rustc 1.40.0-nightly (246be7e 2019-10-25))
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 13, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 13, 2019
Add some tests for fixed ICEs
Closesrust-lang#30904 (fixed between nightly-2019-07-14 and nightly-2019-07-31)
Closesrust-lang#40231 (example 1 is fixed in 1.32.0, example 2 is fixed in 1.38.0)
Closesrust-lang#52432 (fixed in rustc 1.40.0-beta.1 (76b4053 2019-11-05))
Closesrust-lang#63279 (fixed in rustc 1.40.0-nightly (246be7e 2019-10-25))
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 13, 2019
bors added a commit that referenced this pull request Nov 13, 2019
Rollup of 14 pull requests
Successful merges:
- #65932 (download .tar.xz if python3 is used)
- #66094 (Fix documentation for `Iterator::count()`.)
- #66166 (rename cfg(rustdoc) into cfg(doc))
- #66186 (Add long error explanation for E0623)
- #66227 (docs: Fix link to BufWriter::flush)
- #66248 (add raw ptr variant of UnsafeCell::get)
- #66292 (add Result::map_or)
- #66297 (Add a callback that allows compiler consumers to override queries.)
- #66317 (Use a relative bindir for rustdoc to find rustc)
- #66330 (Improve non-exhaustiveness handling in usefulness checking)
- #66331 (Add some tests for fixed ICEs)
- #66334 (Move Session fields to CrateStore)
- #66335 (Move self-profile infrastructure to data structures)
- #66337 (Remove dead code for encoding/decoding lint IDs)
Failed merges:
r? @ghost
@bors
bors merged commit 74d45af into rust-lang:masterNov 13, 2019
@JohnTitor
JohnTitor deleted the add-tests branch November 13, 2019 16:44
@eddyb

Copy link
Copy Markdown
Contributor

There was some confusion, #30904 is not fixed, #30906 was.
We can probably just rename the test though? Or maybe use the example from #30906?

@JohnTitor

Copy link
Copy Markdown
MemberAuthor

@eddyb Ah, sorry! I'll submit the fix later.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-type_alias_impl_trait`#[feature(type_alias_impl_trait)]`F-unboxed_closures`#![feature(unboxed_closures)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

5 participants

@JohnTitor@Centril@bors@eddyb@rust-highfive