Skip to content

Fix link to Extend in Vec::set_len - #66360

Merged
bors merged 1 commit into
rust-lang:masterfrom
elichai:2019-11-vec-link
Nov 14, 2019
Merged

Fix link to Extend in Vec::set_len#66360
bors merged 1 commit into
rust-lang:masterfrom
elichai:2019-11-vec-link

Conversation

@elichai

@elichaielichai commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Fixes#66354

Unrelated to this PR, I think we should stop using ../../std/MODULE and replace it with ../MODULE that way if you're looking at docs in core or alloc clicking at a link won't forward you to std.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2019
@elichai

Copy link
Copy Markdown
ContributorAuthor

r? @steveklabnik (https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md says that he's the guy for docs)

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 0cd111f has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 14, 2019
Fix link to Exten in Vec::set_len
Fixesrust-lang#66354
Unrelated to this PR, I think we should stop using `../../std/MODULE` and replace it with `../MODULE` that way if you're looking at docs in `core` or `alloc` clicking at a link won't forward you to `std`.
@JohnTitorJohnTitor mentioned this pull request Nov 14, 2019
bors added a commit that referenced this pull request Nov 14, 2019
Rollup of 9 pull requests
Successful merges:
- #66253 (Improve errors after re rebalance coherence)
- #66264 (fix an ICE in macro's diagnostic message)
- #66349 (expand source_util macros with def-site context)
- #66351 (Tweak non-char/numeric in range pattern diagnostic)
- #66360 (Fix link to Exten in Vec::set_len)
- #66361 (parser: don't use `unreachable!()` in `fn unexpected`.)
- #66363 (Improve error message in make_tests)
- #66369 (compiletest: Obtain timestamps for common inputs only once)
- #66372 (Fix broken links in Ipv4Addr::is_benchmarking docs)
Failed merges:
r? @ghost
@bors
bors merged commit 0cd111f into rust-lang:masterNov 14, 2019
@elichai
elichai deleted the 2019-11-vec-link branch November 20, 2019 13:29
@dtolnaydtolnay changed the title Fix link to Exten in Vec::set_lenFix link to Extend in Vec::set_lenMar 24, 2024
@dtolnaydtolnay assigned dtolnay and unassigned steveklabnikMar 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vec::set_len docs contains dead link to extend

5 participants

@elichai@rust-highfive@dtolnay@bors@steveklabnik