Skip to content

Do not ICE on recovery from unmet associated type bound obligation - #66388

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:melt-ice
Nov 15, 2019
Merged

Do not ICE on recovery from unmet associated type bound obligation#66388
bors merged 2 commits into
rust-lang:masterfrom
estebank:melt-ice

Conversation

@estebank

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2019
@estebank

Copy link
Copy Markdown
ContributorAuthor

@estebankestebank added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2019
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@Centril

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit bc1bd95 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2019
@Centril

Copy link
Copy Markdown
Contributor

@bors r- for now due to Niko's comments :)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 14, 2019
@Centril

Copy link
Copy Markdown
Contributor

Excellent! @bors r+ rollup

@bors

bors commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit b884205 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 15, 2019
Do not ICE on recovery from unmet associated type bound obligation
Fixrust-lang#66353.
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 15, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 15, 2019
Do not ICE on recovery from unmet associated type bound obligation
Fixrust-lang#66353.
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 15, 2019
bors added a commit that referenced this pull request Nov 15, 2019
Rollup of 12 pull requests
Successful merges:
- #65557 (rename Error::iter_chain() and remove Error::iter_sources())
- #66013 (Avoid hashing the key twice in `get_query()`.)
- #66306 (Remove cannot mutate statics in initializer of another static error)
- #66338 (Update mdbook.)
- #66388 (Do not ICE on recovery from unmet associated type bound obligation)
- #66390 (Fix ICE when trying to suggest `Type<>` instead of `Type()`)
- #66391 (Do not ICE in `if` without `else` in `async fn`)
- #66394 (Fix two OOM issues related to `ConstProp`)
- #66398 (Remove some stack frames from `.async` calls)
- #66410 (miri: helper methods for max values of machine's usize/isize)
- #66418 (Link to tracking issue in HIR const-check error code description)
- #66419 (Don't warn labels beginning with `_` on unused_labels lint)
Failed merges:
r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 15, 2019
Do not ICE on recovery from unmet associated type bound obligation
Fixrust-lang#66353.
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Nov 15, 2019
bors added a commit that referenced this pull request Nov 15, 2019
Rollup of 12 pull requests
Successful merges:
- #65557 (rename Error::iter_chain() and remove Error::iter_sources())
- #66013 (Avoid hashing the key twice in `get_query()`.)
- #66306 (Remove cannot mutate statics in initializer of another static error)
- #66338 (Update mdbook.)
- #66388 (Do not ICE on recovery from unmet associated type bound obligation)
- #66390 (Fix ICE when trying to suggest `Type<>` instead of `Type()`)
- #66391 (Do not ICE in `if` without `else` in `async fn`)
- #66398 (Remove some stack frames from `.async` calls)
- #66410 (miri: helper methods for max values of machine's usize/isize)
- #66418 (Link to tracking issue in HIR const-check error code description)
- #66419 (Don't warn labels beginning with `_` on unused_labels lint)
- #66428 (Cleanup unused function)
Failed merges:
r? @ghost
@bors
bors merged commit b884205 into rust-lang:masterNov 15, 2019
@pnkfelix

Copy link
Copy Markdown
Contributor

beta-accepted (last week, sorry for delay!)

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 21, 2019
@pnkfelix

Copy link
Copy Markdown
Contributor

stable-accepted

@pnkfelixpnkfelix added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Nov 21, 2019
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Dec 5, 2019
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 5, 2019
bors added a commit that referenced this pull request Dec 7, 2019
[beta] backports
This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.
* Handle non_exhaustive in borrow checking #66722
* Do not ICE on trait aliases with missing obligations #66392
* Do not ICE in `if` without `else` in `async fn` #66391
* Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
* Do not ICE on recovery from unmet associated type bound obligation #66388
* find_deprecation: deprecation attr may be ill-formed meta. #66381
* parser: don't use `unreachable!()` in `fn unexpected`. #66361
* Undo an assert causing an ICE until we fix the underlying problem #66250
* Do not ICE with a precision flag in formatting str and no format arguments #66093
* Fix two OOM issues related to `ConstProp` #66394
bors added a commit that referenced this pull request Dec 8, 2019
[beta] backports
This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.
* Handle non_exhaustive in borrow checking #66722
* Do not ICE on trait aliases with missing obligations #66392
* Do not ICE in `if` without `else` in `async fn` #66391
* Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
* Do not ICE on recovery from unmet associated type bound obligation #66388
* find_deprecation: deprecation attr may be ill-formed meta. #66381
* parser: don't use `unreachable!()` in `fn unexpected`. #66361
* Undo an assert causing an ICE until we fix the underlying problem #66250
* Do not ICE with a precision flag in formatting str and no format arguments #66093
* Fix two OOM issues related to `ConstProp` #66394
@Mark-SimulacrumMark-Simulacrum removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE when using reference variable from iterator (instead of copying it): thread 'rustc' panicked at 'already borrowed: BorrowMutError'

7 participants

@estebank@Centril@bors@pnkfelix@nikomatsakis@Mark-Simulacrum@rust-highfive