Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #66446
Closed
Centril wants to merge 30 commits into
Closed
Conversation
Push `ast::{ItemKind, ImplItemKind}::OpaqueTy` hack down into lowering
We currently have a hack in the form of `ast::{ItemKind, ImplItemKind}::OpaqueTy` which is constructed literally when you write `type Alias = impl Trait;` but not e.g. `type Alias = Vec<impl Trait>;`. Per rust-lang/rfcs#2515, this needs to change to allow `impl Trait` in nested positions. This PR achieves this change for the syntactic aspect but not the semantic one, which will require changes in lowering and def collection. In the interim, `TyKind::opaque_top_hack` is introduced to avoid knock-on changes in lowering, collection, and resolve. These hacks can then be removed and fixed one by one until the desired semantics are supported.
r? @varkor…excrichton Add --force-run-in-process unstable option to libtest When running tests with `-Zpanic_abort_tests`, it's sometimes desirable to fall back to the old behavior of only running tests in-process. This comes in handy if the system process launcher is unavailable, or the test code somehow expects all tests to be run in the same process. For example, in Fuchsia we have unit tests that actually test the process launcher itself, in which case we can't use the process launcher to run the tests :). r? @alexcrichton cc @cramertj,@petrhosek
Add a regression test for rust-lang#62524Closesrust-lang#62524
Correct `const_in_array_repeat_expressions` feature name Fixesrust-lang#66433 r? @estebank
… r=Mark-Simulacrum Port erased cleanup Just realised that the changes I made in rust-lang#65965 were removed after the move of all error codes so here it is. I made them into separate commits to make the history look better this time. r? @Mark-Simulacrum
Centril
commented
Nov 15, 2019
ContributorAuthor
@bors r+ rollup=never p=5 |
bors
commented
Nov 15, 2019
Collaborator
📌 Commit 3294f41 has been approved by |
bors
commented
Nov 15, 2019
Collaborator
⌛ Testing commit 3294f41 with merge b7258fcc9770ecb93582f7902a21232e2f3c1e7a... |
tmandry
commented
Nov 15, 2019
Member
@bors r- retry |
rust-highfive
commented
Nov 15, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ast::{ItemKind, ImplItemKind}::OpaqueTyhack down into lowering #66197 (Pushast::{ItemKind, ImplItemKind}::OpaqueTyhack down into lowering)const_in_array_repeat_expressionsfeature name #66435 (Correctconst_in_array_repeat_expressionsfeature name)Failed merges:
r? @ghost