Uh oh!
There was an error while loading. Please reload this page.
Move DIAGNOSTICS usage to rustc_driver - #66456
Merged
Merged
Conversation
rust-highfive
commented
Nov 15, 2019
Contributor
Some changes occurred in diagnostic error codes |
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
I'm not sure it's entirely worth doing this; it feels like the code is not significantly better and the improvement in compile times (2 crates -- rustc_interface and rustc_driver before, just rustc_driver now) is not really significant as neither crate is all that large.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Nov 15, 2019
Member
Modulo those nits and if you think it's worth it then r=me. |
Centrilforce-pushed
the
driver-codes
branch
2 times, most recently
from
November 15, 2019 20:03
4a86489 to
f55a2e7CompareCentril
commented
Nov 15, 2019
ContributorAuthor
@Mark-Simulacrum It's not a big win, but still, a bit of cleanup and a small recompilation win here and there builds to something larger. ^^ |
Mark-Simulacrum
approved these changes
Nov 15, 2019
Mark-Simulacrum
commented
Nov 15, 2019
Member
@bors r+ |
bors
commented
Nov 15, 2019
Collaborator
📌 Commit f55a2e7dd791c8fe845e01149fe1d835c19e78ac has been approved by |
This comment has been minimized.
This comment has been minimized.
Centril
commented
Nov 15, 2019
ContributorAuthor
@bors r- ^ |
Centril
commented
Nov 15, 2019
ContributorAuthor
Moved the macro back to avoid the problem with the index page; I'll wait with r=you for a bit. |
This comment has been minimized.
This comment has been minimized.
Centril
commented
Nov 17, 2019
ContributorAuthor
@bors r=Mark-Simulacrum |
bors
commented
Nov 17, 2019
Collaborator
📌 Commit 8444e16 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 17, 2019
…crum Move `DIAGNOSTICS` usage to `rustc_driver` Remove `rustc_interface`'s dependency on `rustc_error_codes` and centralize all usages of `DIAGNOSTICS` in `rustc_driver`. Once we remove all references to `rustc_error_codes` in all other crates but `rustc_driver`, this should allow for incremental recompilation of the compiler to be smoother when tweaking error codes. This works towards rust-lang#66210 (comment). (May include traces of minor drive-by cleanup.) r? @Mark-Simulacrum
bors added a commit
that referenced
this pull request
Nov 17, 2019
Rollup of 11 pull requests Successful merges: - #65739 (Improve documentation of `Vec::split_off(...)`) - #66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - #66344 (rustc_plugin: Remove `Registry::register_attribute`) - #66381 (find_deprecation: deprecation attr may be ill-formed meta.) - #66395 (Centralize panic macro documentation) - #66456 (Move `DIAGNOSTICS` usage to `rustc_driver`) - #66465 (add missing 'static lifetime in docs) - #66466 (miri panic_unwind: fix hack for SEH platforms) - #66469 (Use "field is never read" instead of "field is never used") - #66471 (Add test for issue 63116) - #66477 (Clarify transmute_copy documentation example) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
rustc_interface's dependency onrustc_error_codesand centralize all usages ofDIAGNOSTICSinrustc_driver. Once we remove all references torustc_error_codesin all other crates butrustc_driver, this should allow for incremental recompilation of the compiler to be smoother when tweaking error codes. This works towards #66210 (comment).(May include traces of minor drive-by cleanup.)
r? @Mark-Simulacrum