Skip to content

Delay an is_local_ever_initialized call. - #66537

Merged
bors merged 1 commit into
rust-lang:masterfrom
nnethercote:delay-is_local_ever_initialized
Nov 22, 2019
Merged

Delay an is_local_ever_initialized call.#66537
bors merged 1 commit into
rust-lang:masterfrom
nnethercote:delay-is_local_ever_initialized

Conversation

@nnethercote

@nnethercotennethercote commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

This commit moves the call after a return that almost always runs. It
speeds up the unicode_normalization benchmark by about 2%.

r? @spastorino

@nnethercote
Delay an is_local_ever_initialized call.
9651617
This commit moves the call after a `return` that almost always runs. It
speeds up the `unicode_normalization` benchmark by about 2%.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2019
@nnethercote

nnethercote commented Nov 19, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 9651617 with merge b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d...

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d (b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d)

@rust-timer

rust-timer commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

Queued b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d with parent 0ccee30, future comparison URL.

@rust-timer

rust-timer commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d, comparison URL.

Centril
Centril reviewed Nov 19, 2019
View reviewed changes
Comment threadsrc/librustc_mir/borrow_check/mod.rs
@Centril

Centril commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

r? @pnkfelix

@nnethercote

nnethercote commented Nov 19, 2019

Copy link
Copy Markdown
ContributorAuthor

The CI perf results match the local ones: unicode_normalization instructions counts are reduced by up to 2.4%. Other benchmarks are unaffected.

@nnethercotennethercote mentioned this pull request Nov 19, 2019
Closed
@spastorino

spastorino commented Nov 19, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Just talked to @Centril about this PR and we can continue with his comments in a follow up PR or issue.
@pnkfelix || @tmandry can you check that?.

@bors r+

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9651617 has been approved by spastorino

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@spastorino

spastorino commented Nov 19, 2019

Copy link
Copy Markdown
Member

@bors rollup

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9651617 has been approved by spastorino

@spastorino

spastorino commented Nov 19, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@bors rollup=never

This is a performance improvement that may mask perf regressions if rolled up.

@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9651617 with merge 564f2d3...

bors added a commit that referenced this pull request Nov 22, 2019
@bors
Auto merge of#66537- nnethercote:delay-is_local_ever_initialized, r…
564f2d3
…=spastorino
Delay an `is_local_ever_initialized` call.
This commit moves the call after a `return` that almost always runs. It
speeds up the `unicode_normalization` benchmark by about 2%.
r? @spastorino
@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: spastorino
Pushing 564f2d3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2019
@bors
bors merged commit 9651617 into rust-lang:masterNov 22, 2019
@nnethercote
nnethercote deleted the delay-is_local_ever_initialized branch November 24, 2019 21:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spastorinospastorinospastorino approved these changes
+2 more reviewers
@pnkfelixpnkfelixpnkfelix left review comments
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pnkfelixpnkfelix

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nnethercote@rust-timer@bors@Centril@spastorino@pnkfelix@rust-highfive