Skip to content

Remove compiler_builtins_lib feature from libstd - #66538

Merged
bors merged 1 commit into
rust-lang:masterfrom
dingelish:master
Nov 19, 2019
Merged

Remove compiler_builtins_lib feature from libstd#66538
bors merged 1 commit into
rust-lang:masterfrom
dingelish:master

Conversation

@dingelish

@dingelishdingelish commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Test if we can close#66368 by this patch.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2019
@Centril

Copy link
Copy Markdown
Contributor

Seems we can.

r? @Centril@bors r+ rollup

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f6b327b has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 19, 2019
Remove compiler_builtins_lib feature from libstd
Test if we can closerust-lang#66368 by this patch.
@CentrilCentril mentioned this pull request Nov 19, 2019
bors added a commit that referenced this pull request Nov 19, 2019
Rollup of 11 pull requests
Successful merges:
- #66090 (Misc CI improvements)
- #66155 (Add long error explanation for E0594)
- #66239 (Suggest calling async closure when needed)
- #66430 ([doc] Fix the source code highlighting on source comments)
- #66431 (Fix 'type annotations needed' error with opaque types)
- #66461 (Add explanation message for E0641)
- #66493 (Add JohnTitor to rustc-guide toolstate notification list)
- #66511 (std::error::Chain: remove Copy)
- #66529 (resolve: Give derive helpers highest priority during resolution)
- #66536 (Move the definition of `QueryResult` into `plumbing.rs`.)
- #66538 (Remove compiler_builtins_lib feature from libstd)
Failed merges:
r? @ghost
@bors
bors merged commit f6b327b into rust-lang:masterNov 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is feature compiler_builtins_lib still needed for libstd?

5 participants

@dingelish@rust-highfive@Centril@bors@alexcrichton