Skip to content

Point at type in let assignment on type errors - #66539

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:let-ty
Nov 24, 2019
Merged

Point at type in let assignment on type errors#66539
bors merged 1 commit into
rust-lang:masterfrom
estebank:let-ty

Conversation

@estebank

@estebankestebank commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Fix#61067.

@rust-highfive

rust-highfive commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2019
estebank
estebank commented Nov 19, 2019
View reviewed changes
Comment threadsrc/test/ui/terminal-width/non-whitespace-trimming-unicode.stderr Outdated
@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Nov 19, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
@Centril

Centril commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

r? @Centril

r=me with refactoring, issue filed, and rustdoc test adjusted

@rust-highfiverust-highfive assigned Centril and unassigned varkorNov 19, 2019
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@estebankestebank mentioned this pull request Nov 19, 2019
Closed
@estebank

estebank commented Nov 19, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 67b8d532a83f965d6d36c4f591797b0475df87fb has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2019
@bors

bors commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #66104) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2019
@estebank

estebank commented Nov 20, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit bca64ce has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
@Centril
Rollup merge ofrust-lang#66539- estebank:let-ty, r=Centril
e6e44cf
Point at type in `let` assignment on type errors
Fixrust-lang#61067.
@CentrilCentril mentioned this pull request Nov 20, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 21, 2019
@Centril
Rollup merge ofrust-lang#66539- estebank:let-ty, r=Centril
6815e4b
Point at type in `let` assignment on type errors
Fixrust-lang#61067.
@CentrilCentril mentioned this pull request Nov 21, 2019
Closed
@Centril

Centril commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

Failed in #66601 (comment), @bors r-

Use --bless --compare-mode=nll to fix the issue.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2019
@bors

This comment has been minimized.

Sign in to view
@Centril

Centril commented Nov 23, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@estebank when you force-push I don't get a notification ;)

@bors

bors commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 34f03c0 has been approved by Centril

@bors

bors commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 23, 2019
@Centril
Rollup merge ofrust-lang#66539- estebank:let-ty, r=Centril
62a7839
Point at type in `let` assignment on type errors
Fixrust-lang#61067.
@CentrilCentril mentioned this pull request Nov 23, 2019
Merged
bors added a commit that referenced this pull request Nov 23, 2019
@bors
Auto merge of#66680- Centril:rollup-1ke3svj, r=Centril
ad808d9
Rollup of 5 pull requests
Successful merges:
- #61351 (Stabilize cfg(doc))
- #66539 (Point at type in `let` assignment on type errors)
- #66655 (rustdoc: Mark `--extern-private` as unstable)
- #66657 (rustdoc: Don't panic when failing to write .lock file)
- #66673 (Move def collector from `rustc` to `rustc_resolve`)
Failed merges:
r? @ghost
@bors
bors merged commit 34f03c0 into rust-lang:masterNov 24, 2019
@bors

bors commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #66680) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Point at cause of expectation for type mismatch on let assignments with explicit type

5 participants

@estebank@rust-highfive@Centril@bors@varkor