GitHub Actions: preparations, part 1 by emilyalbini · Pull Request #66569 · rust-lang/rust

emilyalbini · 2019-11-20T09:41:51Z

This PR adds the first batch of commits in preparation for GitHub Actions:

Added GitHub Actions support in src/ci/shared.sh and bootstrap.
Addded a setup-environment.sh script which guesses and sets the DEPLOY, DEPLOY_ALT and IMAGE environment variables automatically, to reduce the verbosity of the CI configuration.

This PR does not yet add any builders on GitHub Actions.

r? @alexcrichton

alexcrichton · 2019-11-20T15:39:57Z

@bors: r+

bors · 2019-11-20T15:39:58Z

📌 Commit b1463bd58327dd8d32e87c19ce3d4d3031b1e118 has been approved by alexcrichton

emilyalbini · 2019-11-20T17:40:40Z

@bors try

Let's see if we can just rollup this.

bors · 2019-11-20T17:40:41Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

emilyalbini · 2019-11-20T17:40:47Z

@bors r- try

bors · 2019-11-20T17:40:59Z

⌛ Trying commit b1463bd58327dd8d32e87c19ce3d4d3031b1e118 with merge f2ab2c5ecc64a7eb12d6cef52fe69f66c8abf264...

emilyalbini · 2019-11-20T17:48:53Z

Of course I forgot some builders share images.

rust-highfive · 2019-11-20T17:49:12Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-20T17:43:40.5197553Z info: removing rustup binaries
2019-11-20T17:43:40.5197794Z info: rustup is uninstalled
2019-11-20T17:43:40.5553832Z Invalid image: dist-x86_64-linux-alt
2019-11-20T17:43:40.5582104Z 2019-11-20T17:43:40.5680054Z ##[error]Bash exited with code '1'.
2019-11-20T17:43:40.5718248Z ##[section]Starting: Checkout
2019-11-20T17:43:40.5720336Z ==============================================================================
2019-11-20T17:43:40.5720413Z Task : Get sources
2019-11-20T17:43:40.5720521Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-20T17:49:19Z

💔 Test failed - checks-azure

emilyalbini · 2019-11-20T18:17:02Z

Changed the script to avoid setting the IMAGE if it's already set and overrode the one for dist-x86_64-linux-alt (the only one with a different one).

@bors try

bors · 2019-11-20T18:17:13Z

⌛ Trying commit b1a5bb0 with merge b64bd82535444e83819addf25b7e92c4925ea7d7...

bors · 2019-11-20T21:10:05Z

☀️ Try build successful - checks-azure
Build commit: b64bd82535444e83819addf25b7e92c4925ea7d7 (b64bd82535444e83819addf25b7e92c4925ea7d7)

emilyalbini · 2019-11-20T21:11:04Z

@bors r=alexcrichton rollup

bors · 2019-11-20T21:11:05Z

📌 Commit b1a5bb0 has been approved by alexcrichton

@alexcrichton

GitHub Actions: preparations, part 1 This PR adds the first batch of commits in preparation for GitHub Actions: * Added GitHub Actions support in `src/ci/shared.sh` and bootstrap. * Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration. This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton

@alexcrichton

GitHub Actions: preparations, part 1 This PR adds the first batch of commits in preparation for GitHub Actions: * Added GitHub Actions support in `src/ci/shared.sh` and bootstrap. * Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration. This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton

Some environment variables (like DEPLOY or DEPLOY_ALT for dist builders, or IMAGE on Linux builders) are set on a lot of builders, and whether they should be present or not can be detected automatically based on the builder name and the platform. This commit simplifies the CI configuration by automatically setting those environment variables.

emilyalbini · 2019-11-22T14:38:10Z

@bors r- try

bors · 2019-11-22T14:38:22Z

⌛ Trying commit 90a37bc with merge 0459a65...

@alexcrichton

GitHub Actions: preparations, part 1 This PR adds the first batch of commits in preparation for GitHub Actions: * Added GitHub Actions support in `src/ci/shared.sh` and bootstrap. * Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration. This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton

bors · 2019-11-22T17:41:25Z

☀️ Try build successful - checks-azure
Build commit: 0459a65 (0459a65e04f24601ccc7f09655ddb5f6dd5c3d50)

emilyalbini · 2019-11-25T08:11:30Z

@bors r=alexcrichton rollup

bors · 2019-11-25T08:11:32Z

📌 Commit 90a37bc has been approved by alexcrichton

@alexcrichton

GitHub Actions: preparations, part 1 This PR adds the first batch of commits in preparation for GitHub Actions: * Added GitHub Actions support in `src/ci/shared.sh` and bootstrap. * Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration. This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton

@alexcrichton

GitHub Actions: preparations, part 1 This PR adds the first batch of commits in preparation for GitHub Actions: * Added GitHub Actions support in `src/ci/shared.sh` and bootstrap. * Addded a `setup-environment.sh` script which guesses and sets the `DEPLOY`, `DEPLOY_ALT` and `IMAGE` environment variables automatically, to reduce the verbosity of the CI configuration. This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton

@ghost

Rollup of 7 pull requests Successful merges: - #65613 (Preserve whitespace inside one-backtick codeblocks) - #66512 (Add unix::process::CommandExt::arg0) - #66569 (GitHub Actions: preparations, part 1) - #66678 (Remove useless line for error index generation) - #66684 (Drive-by cleanup in region naming) - #66694 (Add some comments to panic runtime) - #66698 (tidy: Remove unused import) Failed merges: r? @ghost

rust-highfive assigned alexcrichton Nov 20, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2019

emilyalbini force-pushed the gha-1 branch 2 times, most recently from ab9d46b to b1a5bb0Compare November 20, 2019 18:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019

Centril mentioned this pull request Nov 20, 2019
Rollup of 6 pull requests #66591
Closed

emilyalbini mentioned this pull request Nov 22, 2019
Rollup of 3 pull requests #66629
Closed

emilyalbini added 3 commits November 22, 2019 15:36

ci: add support for GitHub Actions in the CI scripts
262ce31

DO NOT MERGE: enable windows try builder
90a37bc

emilyalbini force-pushed the gha-1 branch from b1a5bb0 to 90a37bcCompare November 22, 2019 14:37

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2019

emilyalbini mentioned this pull request Nov 25, 2019
Rollup of 6 pull requests #66732
Closed

emilyalbini mentioned this pull request Nov 25, 2019
Rollup of 7 pull requests #66739
Merged

bors merged commit 90a37bc into rust-lang:masterNov 25, 2019

emilyalbini deleted the gha-1 branch November 26, 2019 13:19

Uh oh!

Uh oh!

Conversation

emilyalbini commented Nov 20, 2019

Uh oh!

alexcrichton commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 20, 2019

Uh oh!

rust-highfive commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

emilyalbini commented Nov 22, 2019

Uh oh!

bors commented Nov 22, 2019

Uh oh!

bors commented Nov 22, 2019

Uh oh!

emilyalbini commented Nov 25, 2019

Uh oh!

bors commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants