Uh oh!
There was an error while loading. Please reload this page.
Update tidy check for error codes testing - #66574
Conversation
Uh oh!
There was an error while loading. Please reload this page.
b03aae2 to
749d731CompareGuillaumeGomez
commented
Nov 20, 2019
Updated. |
Mark-Simulacrum
commented
Nov 20, 2019
Could you also say a bit about what this is doing? i.e., what is the goal of this PR, what are we trying to change, and why? I don't have the time to dig into that myself so it'd make an r+ easier on my end. |
GuillaumeGomez
commented
Nov 20, 2019
Sure. Now that all the error codes have been grouped into one file, we moved the long error explanations into markdown files, which means that we need to read those markdown file to also count their code blocks as well. So 2 "big" things happened here:
|
There was a problem hiding this comment.
Could we use fs::read_to_string here? Seems like there's no reason why not?
Mark-Simulacrum
commented
Nov 20, 2019
For the future it'd be great to include that information in the commit; I've copied it into the PR description. r=me with last nit fixed |
749d731 to
df9fed1CompareGuillaumeGomez
commented
Nov 21, 2019
Indeed, sorry... |
Mark-Simulacrum
commented
Nov 21, 2019
@bors r+ |
bors
commented
Nov 21, 2019
📌 Commit df9fed1 has been approved by |
…-check, r=Mark-Simulacrum Update tidy check for error codes testing Now that all the error codes have been grouped into one file, we moved the long error explanations into markdown files, which means that we need to read those markdown file to also count their code blocks as well. So 2 "big" things happened here: * No more need to keep the current error code when reading the `error_codes.rs` file since it's been put into the equivalent markdown file. * Need to instead read the markdown file (but it's simpler since I can just look for code blocks directly).
Now that all the error codes have been grouped into one file, we moved the long error explanations into markdown files, which means that we need to read those markdown file to also count their code blocks as well.
So 2 "big" things happened here:
error_codes.rsfile since it's been put into the equivalent markdown file.