Skip to content

Aggregation of drive-by cosmetic changes for trait-upcasting PR - #66610

Merged
bors merged 2 commits into
rust-lang:masterfrom
alexreg:trait-upcasting-cosmetic
Nov 22, 2019
Merged

Aggregation of drive-by cosmetic changes for trait-upcasting PR#66610
bors merged 2 commits into
rust-lang:masterfrom
alexreg:trait-upcasting-cosmetic

Conversation

@alexreg

@alexregalexreg commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

Cherry-picked from #60900.

As requested by @Centril (and @nikomatsakis, I believe).

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2019
@bors

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Nov 21, 2019
View reviewed changes
Comment threadsrc/librustc/traits/auto_trait.rs Outdated
Comment threadsrc/librustc/traits/auto_trait.rs Outdated
Comment threadsrc/librustc/traits/auto_trait.rs Outdated
Comment threadsrc/librustc/traits/auto_trait.rs Outdated
Comment threadsrc/librustc/traits/mod.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_mir/monomorphize/collector.rs Outdated
@Centril

Centril commented Nov 21, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks; r=me with comments ^--- addressed.

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2019
@Centril

Centril commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

Fairly bit-rotty; @bors p=1

@alexreg

alexreg commented Nov 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril p=1

@bors

bors commented Nov 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1b2de17 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2019
@bors

bors commented Nov 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1b2de17 with merge f11759d...

bors added a commit that referenced this pull request Nov 21, 2019
@bors
Auto merge of#66610- alexreg:trait-upcasting-cosmetic, r=Centril
f11759d
Aggregation of drive-by cosmetic changes for trait-upcasting PR
Cherry-picked from #60900.
As requested by @Centril (and @nikomatsakis, I believe).
r? @Centril
@bors

bors commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing f11759d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2019
@bors
bors merged commit 1b2de17 into rust-lang:masterNov 22, 2019
@borsbors mentioned this pull request Nov 22, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexreg@bors@Centril@rust-highfive