Uh oh!
There was an error while loading. Please reload this page.
remove the 'dereferenceable' attribute from Box - #66645
Conversation
jonas-schievink
commented
Nov 22, 2019
@bors try |
bors
commented
Nov 22, 2019
⌛ Trying commit be07911 with merge d7c557381942c3cac82b5e4585f195ec369c2f68... |
RalfJung
commented
Nov 22, 2019
@rust-timer queue |
rust-timer
commented
Nov 22, 2019
Awaiting bors try build completion |
bors
commented
Nov 22, 2019
☀️ Try build successful - checks-azure |
rust-timer
commented
Nov 22, 2019
Queued d7c557381942c3cac82b5e4585f195ec369c2f68 with parent 083b5a0, future comparison URL. |
rust-timer
commented
Nov 23, 2019
Finished benchmarking try commit d7c557381942c3cac82b5e4585f195ec369c2f68, comparison URL. |
RalfJung
commented
Nov 23, 2019
@Mark-Simulacrum this said "finished benchmarking" but there are no results at the comparison URL yet? |
bjorn3
commented
Nov 23, 2019
@RalfJung It does now. It takes some time before the parent commit gets benchmarked after |
RalfJung
commented
Nov 23, 2019
I see. Timings look like noise. But this is not necessarily a good benchmark. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eddyb
commented
Nov 26, 2019
r=me if there are no concerns left (e.g. perf) |
RalfJung
commented
Nov 26, 2019
@pnkfelix so how do we proceed? I guess we should nominate this for T-lang and T-compiler discussion? |
pnkfelix
commented
Nov 29, 2019
@bors r+ rollup=never |
bors
commented
Nov 29, 2019
📌 Commit d0b9833 has been approved by |
pnkfelix
commented
Nov 29, 2019
(I marked as rollup=never because its not totally certain that there won't be performance regressions associated with this, and I'd rather pay the cost of an extra bors cycle up front than have to track that down in a rollup or have it otherwise masked by unrelated improvements in a rollup.) |
bors
commented
Nov 29, 2019
bors
commented
Nov 29, 2019
☀️ Test successful - checks-azure |
Fixes#66600
r? @eddyb@rkruppe