Skip to content

rustc_plugin: Remove support for syntactic plugins - #66647

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nosynt
Nov 24, 2019
Merged

rustc_plugin: Remove support for syntactic plugins#66647
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nosynt

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Nov 22, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

This part of the plugin interface was successfully replaced by token-based procedural macros in theory and in practice.

cc #29597
cc #64675
r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2019
@petrochenkov

petrochenkov commented Nov 22, 2019

Copy link
Copy Markdown
ContributorAuthor

This is a full version of #64665 (@matklad@Mark-Simulacrum )

Centril
Centril reviewed Nov 22, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💖

Comment threadsrc/librustc_plugin_impl/registry.rs Outdated
Comment threadsrc/librustc_plugin_impl/registry.rs Outdated
Comment threadsrc/test/ui-fulldeps/plugin-args-2.rs Outdated
Comment threadsrc/test/ui-fulldeps/plugin-as-extern-crate.rs Outdated
@Centril

Centril commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

r=me with comments addressed (except for the second re. llvm)

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2019
@petrochenkov

petrochenkov commented Nov 23, 2019

Copy link
Copy Markdown
ContributorAuthor

ping @rust-lang/compiler @rust-lang/lang
This PR removes user-defined syntax extensions.
Please leave a comment if you think this needs an FCP.

@joshtriplett

joshtriplett commented Nov 23, 2019

Copy link
Copy Markdown
Member

I think I remember us already signing off on the removal of plugins in another issue? I don't think we need to sign off again.

@petrochenkov

petrochenkov commented Nov 24, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f89e6c8 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2019
@bors

bors commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f89e6c8 with merge 412f43a...

bors added a commit that referenced this pull request Nov 24, 2019
@bors
Auto merge of#66647- petrochenkov:nosynt, r=Centril
412f43a
rustc_plugin: Remove support for syntactic plugins
This part of the plugin interface was successfully replaced by token-based procedural macros in theory and in practice.
cc #29597
cc #64675
r? @Centril
@borsbors mentioned this pull request Nov 24, 2019
Merged
@bors

bors commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 412f43a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2019
@bors
bors merged commit f89e6c8 into rust-lang:masterNov 24, 2019
@borsbors mentioned this pull request Nov 24, 2019
Merged
@ehussehuss mentioned this pull request Nov 25, 2019
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Nov 25, 2019
@bors
Auto merge of#7630- ehuss:remove-plugin-tests, r=alexcrichton
9eb1f0e
Remove failing plugin tests.
Some rustc plugin features have been removed in rust-lang/rust#66647, so these tests can no longer pass.
@cjgillotcjgillot mentioned this pull request Aug 7, 2022
Closed
@petrochenkov
petrochenkov deleted the nosynt branch February 22, 2025 18:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@Centril@joshtriplett@bors@rust-highfive