Uh oh!
There was an error while loading. Please reload this page.
Don't warn about snake case for field puns. - #66660
Merged
bors merged 1 commit intoJan 18, 2020
Merged
Conversation
rust-highfive
commented
Nov 23, 2019
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
jumbatm
commented
Nov 23, 2019
ContributorAuthor
This comment has been minimized.
This comment has been minimized.
Centril
commented
Nov 23, 2019
Contributor
The test case seems good. |
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
November 24, 2019 10:49
bae7c48 to
9f5e966Compare
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
November 25, 2019 08:42
9f5e966 to
e205c38Compare
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
3 times, most recently
from
December 9, 2019 09:44
ef58c8b to
5306528Comparejumbatm
commented
Dec 9, 2019
ContributorAuthor
@joshtriplett This is good for review for the actual changes now :) |
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
December 22, 2019 07:17
5306528 to
6117582Comparejumbatm
commented
Dec 22, 2019
ContributorAuthor
@rustbot modify labels to -S-waiting-on-author, +S-waiting-on-review |
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
December 22, 2019 14:26
6117582 to
03d5275Compare
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
December 27, 2019 06:42
03d5275 to
2eb486fCompare
This comment has been minimized.
This comment has been minimized.
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
December 27, 2019 08:26
2eb486f to
f4793a9CompareDylan-DPC-zz
commented
Jan 16, 2020
ferris wheel begins r? @Centril |
Centril
reviewed
Jan 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Jan 16, 2020
Contributor
r=me rollup with the file renamed and the commits squashed into one. |
jumbatmforce-pushed
the
dont_warn_about_snake_case_in_patterns
branch
from
January 16, 2020 20:00
f4793a9 to
25a8f94Comparejumbatm
commented
Jan 17, 2020
ContributorAuthor
Done |
Dylan-DPC-zz
commented
Jan 17, 2020
@bors r=centril rollup |
bors
commented
Jan 17, 2020
Collaborator
📌 Commit 25a8f94 has been approved by |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 17, 2020
…in_patterns, r=centril Don't warn about snake case for field puns. Closesrust-lang#66362.
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 18, 2020
…in_patterns, r=centril Don't warn about snake case for field puns. Closesrust-lang#66362.
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 18, 2020
…in_patterns, r=centril Don't warn about snake case for field puns. Closesrust-lang#66362.
bors added a commit
that referenced
this pull request
Jan 18, 2020
Rollup of 9 pull requests Successful merges: - #66660 (Don't warn about snake case for field puns.) - #68093 (Fix deref impl typedef) - #68204 (Use named fields for `{ast,hir}::ItemKind::Impl`) - #68256 (Do not ICE on malformed suggestion spans) - #68279 (Clean up E0198 explanation) - #68291 (Update sanitizer tests) - #68312 (Add regression test for integer literals in generic arguments in where clauses) - #68314 (Stop treating `FalseEdges` and `FalseUnwind` as having semantic value for const eval) - #68317 (Clean up E0199 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#66362.