Skip to content

Ast address-of - #66671

Merged
bors merged 3 commits into
rust-lang:masterfrom
matthewjasper:ast-address-of
Nov 25, 2019
Merged

Ast address-of#66671
bors merged 3 commits into
rust-lang:masterfrom
matthewjasper:ast-address-of

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Nov 23, 2019

Copy link
Copy Markdown
Contributor

This is the parts of #64588 that don't affect MIR. If an address-of expression makes it to MIR lowering we error and lower to the best currently expressible approximation to limit further errors.

r? @Centril

@matthewjaspermatthewjasper added the F-raw_ref_op `#![feature(raw_ref_op)]` label Nov 23, 2019
@rust-highfive

rust-highfive commented Nov 23, 2019

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019
@matthewjaspermatthewjasper mentioned this pull request Nov 23, 2019
Merged
@rust-highfive

This comment has been minimized.

Sign in to view
GuillaumeGomez
GuillaumeGomez requested changes Nov 23, 2019
View reviewed changes
Comment threadsrc/librustc_error_codes/error_codes/E0745.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0745.md Outdated
Centril
Centril reviewed Nov 23, 2019
View reviewed changes
Comment threadsrc/libsyntax/mut_visit.rs Outdated
Comment threadsrc/librustc_parse/parser/expr.rs Outdated
Comment threadsrc/librustc_typeck/check/expr.rs Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0745.md Outdated
Comment threadsrc/librustc_typeck/check/regionck.rs Outdated
Comment threadsrc/librustc_typeck/check/expr.rs Outdated
Comment threadsrc/librustc_typeck/check/expr.rs Outdated
Comment threadsrc/test/ui/raw-ref-op/raw-ref-temp-deref.rs Outdated
Comment threadsrc/test/ui/raw-ref-op/raw-ref-temp-deref.rs Outdated
Comment threadsrc/test/ui/raw-ref-op/raw-ref-temp.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2019
RalfJung
RalfJung reviewed Nov 24, 2019
View reviewed changes
Comment threadsrc/librustc/hir/mod.rs Outdated
@matthewjaspermatthewjasper mentioned this pull request Nov 24, 2019
Open
@CentrilCentril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2019
Centril
Centril approved these changes Nov 24, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when green

@matthewjasper

matthewjasper commented Nov 24, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Nov 24, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f4efc5d has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019
@bors

bors commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f4efc5d with merge c9bacb7...

bors added a commit that referenced this pull request Nov 25, 2019
@bors
Auto merge of#66671- matthewjasper:ast-address-of, r=Centril
c9bacb7
Ast address-of
This is the parts of #64588 that don't affect MIR. If an address-of expression makes it to MIR lowering we error and lower to the best currently expressible approximation to limit further errors.
r? @Centril
@bors

bors commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing c9bacb7 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2019
@bors
bors merged commit f4efc5d into rust-lang:masterNov 25, 2019
@rust-highfiverust-highfive mentioned this pull request Nov 25, 2019
Closed
@rust-highfive

rust-highfive commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #66671!

Tested on commit c9bacb7.
Direct link to PR: #66671

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 25, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#66671!
5ea12a1
Tested on commit rust-lang/rust@c9bacb7.
Direct link to PR: <rust-lang/rust#66671>
💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq, @rust-lang/infra).
@borsbors mentioned this pull request Nov 25, 2019
Merged
@matthewjasper
matthewjasper deleted the ast-address-of branch November 25, 2019 06:47
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 25, 2019
@flip1995
Rustup torust-lang/rust#66671
d43c424
@flip1995flip1995 mentioned this pull request Nov 25, 2019
Merged
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of#4846- flip1995:rustup, r=Manishearth
ff930d3
Rustup
Rustups:
- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of#4846- flip1995:rustup, r=Manishearth
a3da0fb
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27)
Rustups:
- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
- http://github.com/rust-lang/rust/pull/66719
changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of#4846- flip1995:rustup, r=Manishearth
7b8e829
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27)
Rustups:
- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
- http://github.com/rust-lang/rust/pull/66719
changelog: none
@matthewjaspermatthewjasper mentioned this pull request Dec 20, 2019
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
@GuillaumeGomezGuillaumeGomezGuillaumeGomez requested changes
+1 more reviewer
@CentrilCentrilCentril approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

F-raw_ref_op`#![feature(raw_ref_op)]`merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewjasper@rust-highfive@bors@RalfJung@Centril@GuillaumeGomez