Add str::strip_prefix and str::strip_suffix by SOF3 · Pull Request #66735 · rust-lang/rust

SOF3 · 2019-11-25T11:49:04Z

Introduces a counterpart for Path::strip_prefix on str.

This was also discussed in https://internals.rust-lang.org/t/pre-pr-path-strip-prefix-counterpart-in-str/11364/.

rust-highfive · 2019-11-25T11:49:08Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-11-26T10:00:45Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-26T09:43:47.1613552Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-26T09:43:47.7506578Z ##[command]git config gc.auto 0
2019-11-26T09:43:47.7512043Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-26T09:43:47.7515935Z ##[command]git config --get-all http.proxy
2019-11-26T09:43:47.7521296Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66735/merge:refs/remotes/pull/66735/merge
---
2019-11-26T09:49:48.6184500Z Compiling serde_json v1.0.40
2019-11-26T09:49:50.3584964Z Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-11-26T09:50:01.1653588Z Finished release [optimized] target(s) in 1m 29s
2019-11-26T09:50:01.1756885Z tidy check
2019-11-26T09:50:02.0755650Z tidy error: /checkout/src/libcore/str/mod.rs:3817: line longer than 100 chars
2019-11-26T09:50:02.0756400Z tidy error: /checkout/src/libcore/str/mod.rs:3853: line longer than 100 chars
2019-11-26T09:50:04.0115782Z Found 486 error codes
2019-11-26T09:50:04.0115983Z Found 0 error codes with no tests
2019-11-26T09:50:04.0116049Z Done!
2019-11-26T09:50:04.0116091Z some tidy checks failed
2019-11-26T09:50:04.0116091Z some tidy checks failed
2019-11-26T09:50:04.0116122Z 2019-11-26T09:50:04.0116148Z 2019-11-26T09:50:04.0117104Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-26T09:50:04.0117215Z 2019-11-26T09:50:04.0117241Z 2019-11-26T09:50:04.0121473Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-26T09:50:04.0121548Z Build completed unsuccessfully in 0:01:33
2019-11-26T09:50:04.0121548Z Build completed unsuccessfully in 0:01:33
2019-11-26T09:50:04.0173203Z == clock drift check ==
2019-11-26T09:50:04.0183789Z local time: Tue Nov 26 09:50:04 UTC 2019
2019-11-26T09:50:04.1675317Z network time: Tue, 26 Nov 2019 09:50:04 GMT
2019-11-26T09:50:04.1675505Z == end clock drift check ==
2019-11-26T09:50:05.5137396Z 2019-11-26T09:50:05.5210336Z ##[error]Bash exited with code '1'.
2019-11-26T09:50:05.5239511Z ##[section]Starting: Checkout
2019-11-26T09:50:05.5241761Z ==============================================================================
2019-11-26T09:50:05.5241818Z Task : Get sources
2019-11-26T09:50:05.5241881Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Alexendoo · 2019-12-04T18:18:46Z

Ping from triage, any updates? @withoutboats

Dylan-DPC-zz · 2019-12-04T23:54:25Z

r? @KodrAus

KodrAus

Naming wise it looks like we've got a few schemes going here: trim vs strip and start/end vs prefix/suffix.

Personally, I think strip_prefix and strip_suffix are nicely discoverable names, and this API is distinct enough from the trim ones in the way it operates that it doesn't seem necessary to me to make them consistent. They can sit out as distinct so users don't have to try compare signatures to see what makes them different.

So this looks good to me! I'll open up a tracking issue and circle back, but r=me if anybody beats me to it 🙂

Dylan-DPC-zz · 2019-12-07T15:27:09Z

@KodrAus can I merge this?

JohnCSimon · 2019-12-14T02:52:06Z

Ping from triage - @KodrAus , see Dylan-DPC's comment

CAD97 · 2019-12-14T19:25:00Z

This still needs the tracking issue created and to be linked up to, then r=@KodrAus.

Dylan-DPC-zz · 2019-12-14T20:11:34Z

Yes. But I don't want to keep the Pr hanging on an issue creation which can happen at a later stage as well

Dylan-DPC-zz · 2019-12-14T20:33:49Z

I've created the tracking issue (#67302)

@bors r+ rollup

bors · 2019-12-14T20:33:51Z

📌 Commit 4718e20 has been approved by Dylan-DPC

dtolnay · 2019-12-15T01:05:06Z

Yes. But I don't want to keep the Pr hanging on an issue creation which can happen at a later stage as well

The PR can't land before tracking issue creation because the issue number needs to go inside the #[unstable(...)] attribute. We shouldn't be merging unstable methods with issue = "0".

@bors r-

Dylan-DPC-zz · 2019-12-15T01:09:51Z

Ah right, my bad 😆

KodrAus · 2019-12-16T02:41:53Z

Whoops! Looks like I preempted my own dropping of the ball here. Thanks for opening the tracking issue @Dylan-DPC.

@bors r+

bors · 2019-12-16T02:41:55Z

📌 Commit 6176051 has been approved by KodrAus

bors · 2019-12-16T02:41:56Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

Add str::strip_prefix and str::strip_suffix Introduces a counterpart for `Path::strip_prefix` on `str`. This was also discussed in https://internals.rust-lang.org/t/pre-pr-path-strip-prefix-counterpart-in-str/11364/.

@ghost

Rollup of 7 pull requests Successful merges: - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`) - #66570 (stabilize Result::map_or) - #66735 (Add str::strip_prefix and str::strip_suffix) - #66771 (Stabilize the `core::panic` module) - #67317 (fix type_name_of_val doc comment) - #67324 (Fix repetition in matches/mod.rs) - #67325 (cleanup with push_fake_read) Failed merges: r? @ghost

@ghost

Rollup of 7 pull requests Successful merges: - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`) - #66570 (stabilize Result::map_or) - #66735 (Add str::strip_prefix and str::strip_suffix) - #66771 (Stabilize the `core::panic` module) - #67317 (fix type_name_of_val doc comment) - #67324 (Fix repetition in matches/mod.rs) - #67325 (cleanup with push_fake_read) Failed merges: r? @ghost

Add str::strip_prefix and str::strip_suffix
9badc33

rust-highfive assigned withoutboats Nov 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2019

jonas-schievink added the T-libs-api [DEPRECATED; DO NOT USE] label Nov 25, 2019

CAD97 reviewed Nov 26, 2019
View reviewed changes

Comment threadsrc/libcore/str/mod.rs Outdated

RalfJung reviewed Nov 26, 2019
View reviewed changes

Comment threadsrc/libcore/str/mod.rs Outdated

RalfJung reviewed Nov 26, 2019
View reviewed changes

Comment threadsrc/libcore/str/mod.rs

Improved comments to clarify sasumptions in str::strip_prefix
2e2e0df

Fixed formatting issues
4718e20

rust-highfive assigned KodrAus and unassigned withoutboats Dec 4, 2019

KodrAus approved these changes Dec 6, 2019
View reviewed changes

Dylan-DPC-zz mentioned this pull request Dec 14, 2019
tracking issue for strip_prefix, strip_suffix for str #67302
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2019

dtolnay requested changes Dec 15, 2019
View reviewed changes

Comment threadsrc/libcore/str/mod.rs Outdated

Set tracking issue for str_strip
6176051

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2019

Centril mentioned this pull request Dec 16, 2019
Rollup of 7 pull requests #67342
Merged

SOF3 requested a review from dtolnay December 16, 2019 13:37

bors merged commit 6176051 into rust-lang:masterDec 16, 2019

SOF3 deleted the feature/str_strip branch December 17, 2019 04:26

kennytm mentioned this pull request Jun 3, 2025
Add trim_prefix and trim_suffix methods to str rust-lang/libs-team#597
Closed

Uh oh!

Uh oh!

Conversation

SOF3 commented Nov 25, 2019

Uh oh!

rust-highfive commented Nov 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rust-highfive commented Nov 26, 2019

Uh oh!

Alexendoo commented Dec 4, 2019

Uh oh!

Dylan-DPC-zz commented Dec 4, 2019

Uh oh!

KodrAus left a comment

Choose a reason for hiding this comment

Uh oh!

Dylan-DPC-zz commented Dec 7, 2019

Uh oh!

JohnCSimon commented Dec 14, 2019

Uh oh!

CAD97 commented Dec 14, 2019

Uh oh!

Dylan-DPC-zz commented Dec 14, 2019

Uh oh!

Dylan-DPC-zz commented Dec 14, 2019

Uh oh!

bors commented Dec 14, 2019

Uh oh!

dtolnay commented Dec 15, 2019

Uh oh!

Uh oh!

Dylan-DPC-zz commented Dec 15, 2019

Uh oh!

KodrAus commented Dec 16, 2019

Uh oh!

bors commented Dec 16, 2019

Uh oh!

bors commented Dec 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants