Adding docs for keyword match, move by DevinR528 · Pull Request #66904 · rust-lang/rust

DevinR528 · 2019-11-30T14:06:33Z

Partial fix of issue #34601.

rust-highfive · 2019-11-30T14:06:36Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-11-30T14:24:15Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-30T14:07:14.0801174Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-30T14:07:14.9860057Z ##[command]git config gc.auto 0
2019-11-30T14:07:14.9862532Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-30T14:07:14.9864014Z ##[command]git config --get-all http.proxy
2019-11-30T14:07:14.9866590Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66904/merge:refs/remotes/pull/66904/merge
---
2019-11-30T14:12:41.1400072Z Done!
2019-11-30T14:12:41.1400106Z some tidy checks failed
2019-11-30T14:12:41.1400152Z 2019-11-30T14:12:41.1400174Z 2019-11-30T14:12:41.1400965Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-30T14:12:41.1401069Z 2019-11-30T14:12:41.1401092Z 2019-11-30T14:12:41.1404289Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-30T14:12:41.1404624Z Build completed unsuccessfully in 0:01:17
2019-11-30T14:12:41.1404624Z Build completed unsuccessfully in 0:01:17
2019-11-30T14:12:41.1439390Z == clock drift check ==
2019-11-30T14:12:41.1447087Z local time: Sat Nov 30 14:12:41 UTC 2019
2019-11-30T14:12:41.4332978Z network time: Sat, 30 Nov 2019 14:12:41 GMT
2019-11-30T14:12:41.4334536Z == end clock drift check ==
2019-11-30T14:12:42.8309409Z 2019-11-30T14:12:42.8411755Z ##[error]Bash exited with code '1'.
2019-11-30T14:12:42.8433344Z ##[section]Starting: Checkout
2019-11-30T14:12:42.8434734Z ==============================================================================
2019-11-30T14:12:42.8434777Z Task : Get sources
2019-11-30T14:12:42.8434813Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-11-30T17:03:40Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-30T15:25:10.1939922Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-30T15:25:10.7658988Z ##[command]git config gc.auto 0
2019-11-30T15:25:10.7662406Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-30T15:25:10.7666743Z ##[command]git config --get-all http.proxy
2019-11-30T15:25:10.7672415Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66904/merge:refs/remotes/pull/66904/merge
---
2019-11-30T16:28:32.3559068Z .................................................................................................... 1600/9312
2019-11-30T16:28:37.1611686Z .................................................................................................... 1700/9312
2019-11-30T16:28:50.4217490Z ........................................i........................................................... 1800/9312
2019-11-30T16:28:58.6121625Z .................................................................................................... 1900/9312
2019-11-30T16:29:13.3136229Z .........................iiiii...................................................................... 2000/9312
2019-11-30T16:29:23.8521530Z .................................................................................................... 2200/9312
2019-11-30T16:29:26.5301730Z .................................................................................................... 2300/9312
2019-11-30T16:29:31.2775343Z .................................................................................................... 2400/9312
2019-11-30T16:29:54.2630229Z .................................................................................................... 2500/9312
---
2019-11-30T16:32:47.1400844Z ...........................i...............i........................................................ 4800/9312
2019-11-30T16:32:58.5046910Z .................................................................................................... 4900/9312
2019-11-30T16:33:05.6065198Z .................................................................................................... 5000/9312
2019-11-30T16:33:14.7361527Z .................................................................................................... 5100/9312
2019-11-30T16:33:23.0336863Z ................................ii.ii...........i................................................... 5200/9312
2019-11-30T16:33:33.3864621Z .................................................................................................... 5400/9312
2019-11-30T16:33:44.3997299Z .................................................................................................... 5500/9312
2019-11-30T16:33:51.9429649Z ..............i..................................................................................... 5600/9312
2019-11-30T16:33:58.8062715Z .................................................................................................... 5700/9312
2019-11-30T16:33:58.8062715Z .................................................................................................... 5700/9312
2019-11-30T16:34:10.9137367Z .................................................................................................... 5800/9312
2019-11-30T16:34:23.9872300Z ii...i..ii...........i.............................................................................. 5900/9312
2019-11-30T16:34:43.7607155Z .................................................................................................... 6100/9312
2019-11-30T16:34:50.3451826Z .................................................................................................... 6200/9312
2019-11-30T16:34:50.3451826Z .................................................................................................... 6200/9312
2019-11-30T16:35:05.4426918Z .......................i..ii........................................................................ 6300/9312
2019-11-30T16:35:28.0046233Z ...........................................................................................i........ 6500/9312
2019-11-30T16:35:29.6124738Z .................................................................................................... 6600/9312
2019-11-30T16:35:32.0937991Z ..................................................................................i................. 6700/9312
2019-11-30T16:35:35.0012703Z .................................................................................................... 6800/9312
---
2019-11-30T16:41:16.5627600Z finished in 6.608
2019-11-30T16:41:16.5841962Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:41:16.7815704Z 2019-11-30T16:41:16.7816971Z running 164 tests
2019-11-30T16:41:19.9158093Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/164
2019-11-30T16:41:22.1763497Z .i.i..iiii..iiiiiii............i.........iii..i.........ii......
2019-11-30T16:41:22.1766409Z 2019-11-30T16:41:22.1774993Z finished in 5.593
2019-11-30T16:41:22.2003952Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:41:22.3785575Z ---
2019-11-30T16:41:24.5323368Z finished in 2.332
2019-11-30T16:41:24.5533701Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:41:24.7282595Z 2019-11-30T16:41:24.7285703Z running 9 tests
2019-11-30T16:41:24.7286628Z iiiiiiiii
2019-11-30T16:41:24.7287415Z 2019-11-30T16:41:24.7299806Z finished in 0.175
2019-11-30T16:41:24.7495498Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:41:24.9394931Z ---
2019-11-30T16:41:45.8580651Z finished in 21.108
2019-11-30T16:41:45.8824941Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:41:46.1038467Z 2019-11-30T16:41:46.1038787Z running 124 tests
2019-11-30T16:42:14.1202288Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i....ii...i.......ii 100/124
2019-11-30T16:42:18.8626931Z .i.i.i......iii.i.....ii
2019-11-30T16:42:18.8627776Z 2019-11-30T16:42:18.8628410Z finished in 32.980
2019-11-30T16:42:18.8639229Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T16:42:18.8639989Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-30T16:55:20.2293821Z 2019-11-30T16:55:20.2294595Z Doc-tests core
2019-11-30T16:55:25.8951613Z 2019-11-30T16:55:25.8951849Z running 2421 tests
2019-11-30T16:55:37.4539187Z ......iiiii......................................................................................... 100/2421
2019-11-30T16:56:01.6771401Z .................................................................................................... 300/2421
2019-11-30T16:56:15.1750688Z ..i................................................................................................. 400/2421
2019-11-30T16:56:15.1750688Z ..i................................................................................................. 400/2421
2019-11-30T16:56:26.5100255Z ..................................................i..i..................iiii........................ 500/2421
2019-11-30T16:56:47.8136087Z .................................................................................................... 700/2421
2019-11-30T16:56:58.7625839Z .................................................................................................... 800/2421
2019-11-30T16:57:09.7875331Z .................................................................................................... 900/2421
2019-11-30T16:57:20.6837143Z .................................................................................................... 1000/2421
---
2019-11-30T17:01:52.0552445Z 2019-11-30T17:01:52.0574881Z running 1003 tests
2019-11-30T17:02:13.1921917Z i................................................................................................... 100/1003
2019-11-30T17:02:25.3261183Z .................................................................................................... 200/1003
2019-11-30T17:02:33.8665395Z ..................iii......i......i...i......i...................................................... 300/1003
2019-11-30T17:02:39.5535056Z .................................................................................................... 400/1003
2019-11-30T17:02:47.5826805Z ..........................................i..i...............F.F...................ii............... 500/1003
2019-11-30T17:03:02.7160197Z .................................................................................................... 700/1003
2019-11-30T17:03:02.7160197Z .................................................................................................... 700/1003
2019-11-30T17:03:10.5184953Z .............................iiii................................................................... 800/1003
2019-11-30T17:03:26.3384217Z .................................................................................................... 900/1003
2019-11-30T17:03:34.1530624Z ...................................................iiii............................................. 1000/1003
2019-11-30T17:03:34.2492677Z failures:
2019-11-30T17:03:34.2494720Z 2019-11-30T17:03:34.2494720Z 2019-11-30T17:03:34.2500360Z ---- keyword_docs.rs - match_keyword (line 820) stdout ----
2019-11-30T17:03:34.2500677Z error: expected `;`, found ``assert_eq``
2019-11-30T17:03:34.2501899Z --> keyword_docs.rs:825:2
2019-11-30T17:03:34.2504097Z 8 | }
2019-11-30T17:03:34.2504097Z 8 | }
2019-11-30T17:03:34.2504316Z | ^ help: add `;` here
2019-11-30T17:03:34.2504676Z 9 | assert_eq!(x, 10);
2019-11-30T17:03:34.2505152Z | --------- unexpected token
2019-11-30T17:03:34.2505331Z 2019-11-30T17:03:34.2505534Z error[E0425]: cannot find function `oh_no` in this scope
2019-11-30T17:03:34.2505989Z --> keyword_docs.rs:832:13
2019-11-30T17:03:34.2506174Z |
2019-11-30T17:03:34.2506338Z 15 | None => oh_no(),
2019-11-30T17:03:34.2506697Z 2019-11-30T17:03:34.2506697Z 2019-11-30T17:03:34.2506859Z error[E0425]: cannot find function `all_other_numbers` in this scope
2019-11-30T17:03:34.2507320Z --> keyword_docs.rs:833:10
2019-11-30T17:03:34.2507541Z |
2019-11-30T17:03:34.2507716Z 16 | _ => all_other_numbers(),
2019-11-30T17:03:34.2507989Z 2019-11-30T17:03:34.2508131Z error: aborting due to 3 previous errors
2019-11-30T17:03:34.2508268Z 2019-11-30T17:03:34.2508863Z For more information about this error, try `rustc --explain E0425`.
2019-11-30T17:03:34.2508863Z For more information about this error, try `rustc --explain E0425`.
2019-11-30T17:03:34.2509834Z Couldn't compile the test.
2019-11-30T17:03:34.2510359Z ---- keyword_docs.rs - match_keyword (line 840) stdout ----
2019-11-30T17:03:34.2510559Z error[E0425]: cannot find function `the_rest` in this scope
2019-11-30T17:03:34.2511252Z --> keyword_docs.rs:851:10
2019-11-30T17:03:34.2511642Z 14 | _ => the_rest(),
2019-11-30T17:03:34.2511818Z | ^^^^^^^^ not found in this scope
2019-11-30T17:03:34.2511945Z 2019-11-30T17:03:34.2512084Z error: aborting due to previous error
---
2019-11-30T17:03:34.2705651Z local time: Sat Nov 30 17:03:34 UTC 2019
2019-11-30T17:03:34.8055714Z network time: Sat, 30 Nov 2019 17:03:34 GMT
2019-11-30T17:03:34.8060571Z == end clock drift check ==
2019-11-30T17:03:35.3704699Z 2019-11-30T17:03:35.3884514Z ##[error]Bash exited with code '1'.
2019-11-30T17:03:35.3932135Z ##[section]Starting: Checkout
2019-11-30T17:03:35.3934255Z ==============================================================================
2019-11-30T17:03:35.3934318Z Task : Get sources
2019-11-30T17:03:35.3934372Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Dylan-DPC-zz · 2019-11-30T20:15:16Z

r? @Dylan-DPC

DevinR528 · 2019-11-30T22:58:40Z

Sorry about cluttering everything up I'm still getting used to everything. That should be it I ran the tidy script on my end first.

DevinR528 · 2019-12-02T00:48:24Z

Thanks for the feed back I made the changes. If I want to do more of these keyword docs should I do as many as I can in one PR or one per PR. First Rust PR!!

Dylan-DPC-zz · 2019-12-02T10:05:43Z

@bors r+ rollup

bors · 2019-12-02T10:05:45Z

📌 Commit e638f7c has been approved by Dylan-DPC

Adding docs for keyword match, move Partial fix of issue rust-lang#34601.

@ghost

Rollup of 6 pull requests Successful merges: - #66148 (Show the sign for signed ops on `exact_div`) - #66651 (Add `enclosing scope` parameter to `rustc_on_unimplemented`) - #66904 (Adding docs for keyword match, move) - #66935 (syntax: Unify macro and attribute arguments in AST) - #66941 (Remove `ord` lang item) - #66967 (Remove hack for top-level or-patterns in match checking) Failed merges: r? @ghost

DevinR528 added 3 commits November 30, 2019 08:54

document match and move keywords
71abce1

add example to move
b67d6c7

add docs for move and match keywords
44f3bee

rust-highfive assigned shepmaster Nov 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2019

remove trailing whitespace
d5a4c62

rust-highfive assigned Dylan-DPC-zz and unassigned shepmaster Nov 30, 2019

fix doc compile fail
c69be48

add ";" for let = match
7c3befc

Dylan-DPC-zz suggested changes Dec 1, 2019
View reviewed changes

Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated

add grammer fixes
e638f7c

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2019

Centril added a commit to Centril/rust that referenced this pull request Dec 3, 2019
Rollup merge ofrust-lang#66904- DevinR528:keyword-doc, r=Dylan-DPC
2f09deb
Adding docs for keyword match, move Partial fix of issue rust-lang#34601.

Centril mentioned this pull request Dec 3, 2019
Rollup of 9 pull requests #66978
Closed

Centril added a commit to Centril/rust that referenced this pull request Dec 3, 2019
Rollup merge ofrust-lang#66904- DevinR528:keyword-doc, r=Dylan-DPC
01345d6
Adding docs for keyword match, move Partial fix of issue rust-lang#34601.

Centril mentioned this pull request Dec 3, 2019
Rollup of 6 pull requests #66982
Merged

bors merged commit e638f7c into rust-lang:masterDec 3, 2019

Navigation Menu

Uh oh!

Uh oh!

Adding docs for keyword match, move - #66904

Adding docs for keyword match, move#66904
bors merged 7 commits into
rust-lang:masterfrom
DevinR528:keyword-doc

DevinR528 commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

Dylan-DPC-zz commented Nov 30, 2019

Uh oh!

DevinR528 commented Nov 30, 2019

Uh oh!

Uh oh!

Uh oh!

DevinR528 commented Dec 2, 2019

Uh oh!

Dylan-DPC-zz commented Dec 2, 2019

Uh oh!

bors commented Dec 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

DevinR528 commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

rust-highfive commented Nov 30, 2019

Uh oh!

Dylan-DPC-zz commented Nov 30, 2019

Uh oh!

DevinR528 commented Nov 30, 2019

Uh oh!

Uh oh!

Uh oh!

DevinR528 commented Dec 2, 2019

Uh oh!

Dylan-DPC-zz commented Dec 2, 2019

Uh oh!

bors commented Dec 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants