Skip to content

Do not ICE on async fn with non-Copy infered type arg - #67004

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:issue-66958
Dec 9, 2019
Merged

Do not ICE on async fn with non-Copy infered type arg#67004
bors merged 2 commits into
rust-lang:masterfrom
estebank:issue-66958

Conversation

@estebank

@estebankestebank commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Fix#66958.

@rust-highfive

rust-highfive commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
Centril
Centril reviewed Dec 4, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-66958.rs Outdated
hellow554
hellow554 reviewed Dec 4, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-66958.rs Outdated
hellow554
hellow554 reviewed Dec 4, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-66958.rs Outdated
hellow554
hellow554 reviewed Dec 4, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-66958.stderr Outdated
@hellow554

hellow554 commented Dec 4, 2019

Copy link
Copy Markdown
Contributor

The u32 field is not needed for the ICE. It was a leftover from the reduction. Feel free to remove it if you like.

@estebank

estebank commented Dec 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Addressed comments.

@bors

bors commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #66815) made this pull request unmergeable. Please resolve the merge conflicts.

eddyb
eddyb approved these changes Dec 5, 2019
View reviewed changes

@eddybeddyb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@estebank

estebank commented Dec 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Dec 6, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7ed9066 has been approved by eddyb

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 7, 2019
@Centril
Rollup merge ofrust-lang#67004- estebank:issue-66958, r=eddyb
6c2232d
Do not ICE on async fn with non-Copy infered type arg
Fixrust-lang#66958.
@CentrilCentril mentioned this pull request Dec 7, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 8, 2019
@Centril
Rollup merge ofrust-lang#67004- estebank:issue-66958, r=eddyb
3fd39b9
Do not ICE on async fn with non-Copy infered type arg
Fixrust-lang#66958.
@CentrilCentril mentioned this pull request Dec 8, 2019
Closed
@bors

bors commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7ed9066 with merge dbbe4f1...

bors added a commit that referenced this pull request Dec 9, 2019
@bors
Auto merge of#67004- estebank:issue-66958, r=eddyb
dbbe4f1
Do not ICE on async fn with non-Copy infered type arg
Fix#66958.
@bors

bors commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing dbbe4f1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2019
@bors
bors merged commit 7ed9066 into rust-lang:masterDec 9, 2019
@borsbors mentioned this pull request Dec 9, 2019
Merged
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Feb 6, 2020
Closed
@estebank
estebank deleted the issue-66958 branch November 9, 2023 05:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@CentrilCentrilCentril left review comments
@hellow554hellow554hellow554 left review comments
@eddybeddybeddyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eddybeddyb

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE on rustc 1.41.0-nightly (25d8a9494 2019-11-29) running on x86_64-apple-darwin

6 participants

@estebank@rust-highfive@hellow554@bors@eddyb@Centril