Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #67060
Merged
Merged
Conversation
Made it the same as rmatches()
When refering to or suggesting raw identifiers, refer to them with `r#`. Fixrust-lang#65634.
In most places, we use a span when emitting `expected...found` errors. However, there were a couple of places where we didn't use any span, resulting in hard-to-interpret error messages. This commit attaches the relevant span to these notes, and additionally switches over to using `note_expected_found` instead of manually formatting the message
the unstables ones in libcore, with the unstable feature disabled, were not checked
So that we can bootstrap successfully
Clarify it is OK to pass a pointer that never owned a weak count (one from Weak::new) back into it as it was created from it. Relates to discussion in rust-lang#60728.
…tolnay weak-into-raw: Clarify some details in Safety Clarify it is OK to pass a pointer that never owned a weak count (one from Weak::new) back into it as it was created from it. Relates to discussion in rust-lang#60728. @CAD97 Do you want to have a look at the new docs?
Check break target availability when checking breaks with values Fixesrust-lang#66702 I'll be adding a regression test.
Fix documentation of pattern for str::matches() Made it the same as rmatches()
capitalize Rust Capitalize "Rust" in docs.
Accurately portray raw identifiers in error messages When refering to or suggesting raw identifiers, refer to them with `r#`. Fixrust-lang#65634.
…r=Dylan-DPC Include a span in more `expected...found` notes In most places, we use a span when emitting `expected...found` errors. However, there were a couple of places where we didn't use any span, resulting in hard-to-interpret error messages. This commit attaches the relevant span to these notes, and additionally switches over to using `note_expected_found` instead of manually formatting the message
E0023: handle expected != tuple pattern type Fixesrust-lang#67037. r? @estebank
…-Simulacrum rustc_parser: cleanup imports Reorganize & canonicalize some imports + Drop `rustc_target` as a dependency. r? @Mark-Simulacrum
Make const-qualification look at more `const fn`s As explained in a lot more detail in rust-lang#67053 this makes const-qualification not ignore the unstable const fns in libcore. r? @oli-obk cc @ecstatic-morse (Still a bit unsure about the `cfg`s here, for bootstrapping, does that seem correct ?) Fixesrust-lang#67053.
Centril
commented
Dec 5, 2019
ContributorAuthor
@bors r+ p=9 rollup=never |
bors
commented
Dec 5, 2019
Collaborator
📌 Commit a008aff has been approved by |
bors
commented
Dec 5, 2019
Collaborator
bors added a commit
that referenced
this pull request
Dec 5, 2019
Rollup of 9 pull requests Successful merges: - #66710 (weak-into-raw: Clarify some details in Safety) - #66863 (Check break target availability when checking breaks with values) - #67002 (Fix documentation of pattern for str::matches()) - #67005 (capitalize Rust) - #67010 (Accurately portray raw identifiers in error messages) - #67011 (Include a span in more `expected...found` notes) - #67044 (E0023: handle expected != tuple pattern type) - #67045 (rustc_parser: cleanup imports) - #67055 (Make const-qualification look at more `const fn`s) Failed merges: r? @ghost
bors
commented
Dec 6, 2019
Collaborator
☀️ Test successful - checks-azure |
This was referenced Dec 6, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
expected...foundnotes #67011 (Include a span in moreexpected...foundnotes)const fns #67055 (Make const-qualification look at moreconst fns)Failed merges:
r? @ghost