Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #67140
Merged
Merged
Conversation
Deleted unused labels from compiler and fixed or allowed unused labels in tests. This patch removes some gratuitous unused labels and turns off the warning for unused labels that are a necessary part of tests. This will permit setting the `unused_labels` lint to `warn`.
…nneeded Index impl, remove body fn rustc_codegen_ssa: Fix BodyAndCache reborrow to Body and change instances of body() call to derefence rustc_mir: Fix BodyAndCache reborrow to Body and change intances of body() call to derefence
`legacy_disrectory_ownership` vs `legacy_directory_ownership`
Change unused_labels from allow to warn Fixesrust-lang#66324, making the unused_labels lint warn instead of allow by default. I'm told @rust-lang/lang will need to review this, and perhaps will want to do a crater run.
Cleanup BodyCache After this PR: - `BodyCache` is renamed to `BodyAndCache` - `ReadOnlyBodyCache` is renamed to `ReadOnlyBodyAndCache` - `ReadOnlyBodyAndCache::body` fn is removed and all calls to it are replaced by a deref (possible due to fix of its `Deref` imp in rust-lang#65947) cc @eddyb@oli-obk
use `#[allow(unused_attributes)]` to paper over incr.comp problem Paper over the problem in rust-lang#58633. r? @Mark-Simulacrum
…chenkov Make `ForeignItem` an alias of `Item`. Working towards the merging of items in AST and syntactically. r? @petrochenkov
Fixes typo `legacy_disrectory_ownership` vs `legacy_directory_ownership`
Centril
commented
Dec 8, 2019
ContributorAuthor
@bors r+ p=5 rollup=never |
bors
commented
Dec 8, 2019
Collaborator
📌 Commit 32e27c2 has been approved by |
bors
commented
Dec 8, 2019
Collaborator
bors added a commit
that referenced
this pull request
Dec 8, 2019
Rollup of 5 pull requests Successful merges: - #66325 (Change unused_labels from allow to warn) - #66991 (Cleanup BodyCache) - #67101 (use `#[allow(unused_attributes)]` to paper over incr.comp problem) - #67114 (Make `ForeignItem` an alias of `Item`.) - #67129 (Fixes typo) Failed merges: - #66886 (Remove the borrow check::nll submodule) r? @ghost
bors
commented
Dec 8, 2019
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Dec 8, 2019
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 8, 2019
Tested on commit rust-lang/rust@e862c01. Direct link to PR: <rust-lang/rust#67140> 💔 miri on windows: test-fail → build-fail (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra). 💔 miri on linux: test-fail → build-fail (cc @oli-obk@eddyb@RalfJung, @rust-lang/infra).
This was referenced Dec 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[allow(unused_attributes)]to paper over incr.comp problem #67101 (use#[allow(unused_attributes)]to paper over incr.comp problem)ForeignIteman alias ofItem. #67114 (MakeForeignIteman alias ofItem.)Failed merges:
r? @ghost