Uh oh!
There was an error while loading. Please reload this page.
Move non clean impls items - #67178
Conversation
rust-highfive
commented
Dec 9, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kinnison
left a comment
There was a problem hiding this comment.
Visually this looks sane, Thank you for making it easy review.
You did end up shunting a couple of functions around a bit, but I'm okay with that, it was easy enough to confirm.
You have a tidy error to fix before I can approve fully.
GuillaumeGomez
commented
Dec 10, 2019
Fixed tidy so let's move! :D @bors: r=kinnison |
bors
commented
Dec 10, 2019
📌 Commit f0babc8 has been approved by |
…, r=kinnison Move non clean impls items This is another (and should be the last for the `clean` module) rustdoc cleanup. I tried to follow the same commit pattern as the last one to make the review as easy as possible. r? @kinnison
Rollup of 9 pull requests Successful merges: - #66377 (Update RELEASES.md for 1.40.0) - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…) - #67152 (Sort auto trait and blanket implementations display) - #67154 (Fix typos in src/libcore/alloc.rs docs) - #67168 (corrected comment in E0478) - #67178 (Move non clean impls items) - #67180 (doc: Use .copied() instead of .cloned() in Vec example) - #67181 (Update hashmap doc) - #67193 (In which we start tracking polonius in `-Z self-profile`) Failed merges: r? @ghost
This is another (and should be the last for the
cleanmodule) rustdoc cleanup.I tried to follow the same commit pattern as the last one to make the review as easy as possible.
r? @kinnison