Uh oh!
There was an error while loading. Please reload this page.
Unify binop wording - #67189
Conversation
rust-highfive
commented
Dec 10, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
commented
Dec 10, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
estebank
commented
Dec 10, 2019
You will need to run |
4b6a7ce to
cd4ca8aCompareLeSeulArtichaut
commented
Dec 10, 2019
@estebank Updated! Thanks a lot, I was going to rewrite every test by hand 😅 |
rust-highfive
commented
Dec 10, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
cd4ca8a to
22e6c75Comparerust-highfive
commented
Dec 11, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
22e6c75 to
e4abcfbCompareLeSeulArtichaut
commented
Dec 15, 2019
@Dylan-DPC What should I modify? |
Dylan-DPC-zz
commented
Dec 15, 2019
You need to fix the tests |
@Dylan-DPC I'm sorry, I don't understand what you want me to do precisely. Do I need to write new tests? Or update the existing tests? |
LeSeulArtichaut
commented
Dec 18, 2019
@estebank Could you maybe help me on this? |
| "binary operation `{}` cannot be applied to type `{}`", | ||
| op.node.as_str(), | ||
| lhs_ty); | ||
| "{}", message.as_str()); |
There was a problem hiding this comment.
I don't think .as_str() is needed here.
estebank
commented
Dec 18, 2019
The tests are already passing. I have some small misgivings about that big block there, but it should be fine. @bors r+ |
bors
commented
Dec 18, 2019
📌 Commit e4abcfb has been approved by |
bors
commented
Dec 18, 2019
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
…tebank Unify binop wording Closesrust-lang#60497 r? @estebank
Rollup of 8 pull requests Successful merges: - #67189 (Unify binop wording) - #67270 (std: Implement `LineWriter::write_vectored`) - #67286 (Fix the configure.py TOML field for a couple LLVM options) - #67321 (make htons const fn) - #67382 (Remove some unnecessary `ATTR_*` constants.) - #67389 (Remove `SO_NOSIGPIPE` dummy variable on platforms that don't use it.) - #67394 (Remove outdated references to @t from comments) - #67406 (Suggest associated type when the specified one cannot be found) Failed merges: r? @ghost
Closes#60497
r? @estebank