Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #67271
Merged
Merged
Conversation
Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks.
Match `VecDeque::extend` to `Vec::extend_desugared` Currently, `VecDeque::extend` [does not reserve at all](rust-lang#65069 (comment)). This implementation still runs a check every iteration of the loop, but should reallocate at most once for the common cases where the `size_hint` lower bound is exact. Further optimizations in the future could improve this for some common cases, but given the complexity of the `Vec::extend` implementation it's not immediately clear that this would be worthwhile.
…KodrAus LinkedList: drop remaining items when drop panics rust-lang#67235, but for `LinkedList`, which has the same issue. I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
Don't suggest wrong snippet in closure Fixesrust-lang#67190 r? @estebank
…Match-MatchedSeq, r=Centril Remove the `DelimSpan` from `NamedMatch::MatchedSeq`. Because it's unused. This then allows the removal of `MatcherPos::sp_open`. It's a tiny perf win, reducing instruction counts by 0.1% - 0.2% on a few benchmarks. r? @Centril
Require `allow_internal_unstable` for stable min_const_fn using unsta… …ble features r? @Centril cc @ecstatic-morse@RalfJung
…ebank parser: recover on `&'lifetime mut? $pat`. r? @estebank
Centril
commented
Dec 13, 2019
ContributorAuthor
@bors r+ p=6 rollup=never |
bors
commented
Dec 13, 2019
Collaborator
📌 Commit d25197c has been approved by |
bors
commented
Dec 13, 2019
Collaborator
bors added a commit
that referenced
this pull request
Dec 13, 2019
Rollup of 6 pull requests Successful merges: - #66341 (Match `VecDeque::extend` to `Vec::extend_desugared`) - #67243 (LinkedList: drop remaining items when drop panics) - #67247 (Don't suggest wrong snippet in closure) - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.) - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…) - #67269 (parser: recover on `&'lifetime mut? $pat`.) Failed merges: r? @ghost
bors
commented
Dec 13, 2019
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
VecDeque::extendtoVec::extend_desugared#66341 (MatchVecDeque::extendtoVec::extend_desugared)DelimSpanfromNamedMatch::MatchedSeq. #67250 (Remove theDelimSpanfromNamedMatch::MatchedSeq.)allow_internal_unstablefor stable min_const_fn using unsta… #67251 (Requireallow_internal_unstablefor stable min_const_fn using unsta…)&'lifetime mut? $pat. #67269 (parser: recover on&'lifetime mut? $pat.)Failed merges:
r? @ghost