Uh oh!
There was an error while loading. Please reload this page.
[beta] Beta backports - #67298
Merged
Merged
Conversation
…y causes an error during evaluation
To avoid potential duplicate diagnostics and separate the error reporting logic
rust-highfive
commented
Dec 14, 2019
Contributor
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Dec 14, 2019
Contributor
|
Mark-Simulacrum
commented
Dec 14, 2019
MemberAuthor
@bors r+ p=10 |
bors
commented
Dec 14, 2019
Collaborator
📌 Commit c403f62 has been approved by |
bors
commented
Dec 14, 2019
Collaborator
bors added a commit
that referenced
this pull request
Dec 14, 2019
[beta] Beta backports Backporting the following pull requests: * resolve: Always resolve visibilities on impl items #67236 * resolve: Resolve visibilities on fields with non-builtin attributes #67106 * E0023: handle expected != tuple pattern type #67044 * Fix `unused_parens` triggers on macro by example code #66983 * Fix some issues with attributes on unnamed fields #66669 * Ensure that we get a hard error on generic ZST constants if their bodies #67134 (via #67297) Some of these conflicted on merge, I resolved where possible, sometimes by cherry-picking a commit or two more from the relevant PRs. Since those changes are necessary though for backport to proceed (otherwise not even std/core compile), seems fine -- they're fairly minor cleanups anyway.
bors
commented
Dec 14, 2019
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting the following pull requests:
unused_parenstriggers on macro by example code Fixunused_parenstriggers on macro by example code #66983Some of these conflicted on merge, I resolved where possible, sometimes by cherry-picking a commit or two more from the relevant PRs. Since those changes are necessary though for backport to proceed (otherwise not even std/core compile), seems fine -- they're fairly minor cleanups anyway.