Skip to content

Don't suppress move errors for union fields - #67314

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:union-move-errors
Dec 21, 2019
Merged

Don't suppress move errors for union fields#67314
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:union-move-errors

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

closes#66500

@rust-highfive

rust-highfive commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2019
@jonas-schievinkjonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2019
@CentrilCentril added the F-untagged_unions `#![feature(untagged_unions)]` label Dec 15, 2019
Centril
Centril reviewed Dec 15, 2019
View reviewed changes
Comment threadsrc/librustc_mir/dataflow/move_paths/builder.rs Outdated
nikomatsakis
nikomatsakis requested changes Dec 19, 2019
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with a comment

Comment threadsrc/librustc_mir/dataflow/move_paths/builder.rs Outdated
@rust-highfive

rust-highfive commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-19T20:29:45.3003049Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-19T20:29:45.3193389Z ##[command]git config gc.auto 0
2019-12-19T20:29:45.3283906Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-19T20:29:45.3331753Z ##[command]git config --get-all http.proxy
2019-12-19T20:29:45.3492794Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67314/merge:refs/remotes/pull/67314/merge
---
2019-12-19T20:40:45.3904767Z configure: build.locked-deps := True
2019-12-19T20:40:45.3905162Z configure: llvm.ccache := sccache
2019-12-19T20:40:45.3905508Z configure: build.cargo-native-static := True
2019-12-19T20:40:45.3905750Z configure: dist.missing-tools := True
2019-12-19T20:40:45.3906113Z configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
2019-12-19T20:40:45.3906245Z configure: writing `config.toml` in current directory
2019-12-19T20:40:45.3908081Z configure: 2019-12-19T20:40:45.3909002Z configure: run `python /checkout/x.py --help`
2019-12-19T20:40:45.3909089Z configure: ---
2019-12-19T20:49:47.2063537Z Build completed successfully in 0:01:47
2019-12-19T20:49:47.2071894Z + /scripts/validate-toolstate.sh
2019-12-19T20:49:47.2140185Z Cloning into 'rust-toolstate'...
2019-12-19T20:49:47.8113797Z Traceback (most recent call last):
2019-12-19T20:49:47.8113917Z File "../../src/tools/publish_toolstate.py", line 303, in <module>
2019-12-19T20:49:47.8114017Z cur_datetime
2019-12-19T20:49:47.8114062Z File "../../src/tools/publish_toolstate.py", line 182, in update_latest
2019-12-19T20:49:47.8114743Z for os in ['windows', 'linux']
2019-12-19T20:49:47.8114816Z File "../../src/tools/publish_toolstate.py", line 182, in <dictcomp>
2019-12-19T20:49:47.8115025Z for os in ['windows', 'linux']
2019-12-19T20:49:47.8115073Z File "../../src/tools/publish_toolstate.py", line 111, in read_current_status
2019-12-19T20:49:47.8115343Z (commit, status) = line.split('\t', 1)
2019-12-19T20:49:47.8115388Z ValueError: need more than 1 value to unpack
2019-12-19T20:49:47.8166511Z local time: Thu Dec 19 20:49:47 UTC 2019
2019-12-19T20:49:48.0930246Z network time: Thu, 19 Dec 2019 20:49:48 GMT
2019-12-19T20:49:48.0934595Z == end clock drift check ==
2019-12-19T20:49:49.6699769Z 2019-12-19T20:49:49.6699769Z 2019-12-19T20:49:49.6806165Z ##[error]Bash exited with code '1'.
2019-12-19T20:49:49.6839627Z ##[section]Starting: Checkout
2019-12-19T20:49:49.6841210Z ==============================================================================
2019-12-19T20:49:49.6841261Z Task : Get sources
2019-12-19T20:49:49.6841324Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matthewjasper

matthewjasper commented Dec 20, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented Dec 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 97219d8 has been approved by nikomatsakis

@bors

bors commented Dec 20, 2019

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 20, 2019
@Centril
Rollup merge ofrust-lang#67314- matthewjasper:union-move-errors, r=…
d9f1f48
…nikomatsakis
Don't suppress move errors for union fields
closesrust-lang#66500
@CentrilCentril mentioned this pull request Dec 20, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Dec 20, 2019
@Centril
Rollup merge ofrust-lang#67314- matthewjasper:union-move-errors, r=…
86282d0
…nikomatsakis
Don't suppress move errors for union fields
closesrust-lang#66500
@CentrilCentril mentioned this pull request Dec 20, 2019
Merged
bors added a commit that referenced this pull request Dec 21, 2019
@bors
Auto merge of#67464- Centril:rollup-j3mkl1m, r=Centril
9ff30a7
Rollup of 6 pull requests
Successful merges:
- #67130 (Const prop should finish propagation into user defined variables)
- #67163 (Split up ptr/mod.rs in libcore...)
- #67314 (Don't suppress move errors for union fields)
- #67392 (Fix unresolved type span inside async object)
- #67404 (Separate region inference logic from error handling better)
- #67428 (`is_binding_pat`: use explicit match & include or-pats in grammar)
Failed merges:
r? @ghost
@bors
bors merged commit 97219d8 into rust-lang:masterDec 21, 2019
@matthewjasper
matthewjasper deleted the union-move-errors branch December 21, 2019 10:51
@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2020
@jonas-schievinkjonas-schievink mentioned this pull request Jan 13, 2020
Merged
bors added a commit that referenced this pull request Jan 14, 2020
@bors
Auto merge of#68189- jonas-schievink:beta-next, r=Mark-Simulacrum
965ce16
[Beta] Backports
I did not include #67134 and #67289 since they seem to be on beta already.
* Fix up Command Debug output when arg0 is specified. #67219
* Do not ICE on unnamed future #67289
* Don't suppress move errors for union fields #67314
* Reenable static linking of libstdc++ on windows-gnu #67410
* Use the correct type for static qualifs #67621
* Treat extern statics just like statics in the "const pointer to static" representation #67630
* Do not ICE on lifetime error involving closures #67687
@jonas-schievinkjonas-schievink removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis requested changes
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkovpetrochenkov

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.F-untagged_unions`#![feature(untagged_unions)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE when trying to move from reference in union

8 participants

@matthewjasper@rust-highfive@bors@nikomatsakis@Centril@pnkfelix@jonas-schievink@petrochenkov