Uh oh!
There was an error while loading. Please reload this page.
Set release channel on non-dist builders - #67351
Merged
Merged
Conversation
Mark-Simulacrum
commented
Dec 16, 2019
MemberAuthor
@bors p=1 since this should fix toolstate publication |
emilyalbini
commented
Dec 16, 2019
Member
@bors r+ p=1 rollup=never Thanks Mark! |
bors
commented
Dec 16, 2019
Collaborator
📌 Commit f365dbc has been approved by |
bors
commented
Dec 16, 2019
Collaborator
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 17, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 18, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Dec 18, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 18, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
bors added a commit
that referenced
this pull request
Dec 18, 2019
Rollup of 5 pull requests Successful merges: - #66716 (Implement `DebugStruct::non_exhaustive`.) - #67286 (Fix the configure.py TOML field for a couple LLVM options) - #67321 (make htons const fn) - #67351 (Set release channel on non-dist builders) - #67382 (Remove some unnecessary `ATTR_*` constants.) Failed merges: r? @ghost
bors added a commit
that referenced
this pull request
Dec 18, 2019
Rollup of 5 pull requests Successful merges: - #66716 (Implement `DebugStruct::non_exhaustive`.) - #67286 (Fix the configure.py TOML field for a couple LLVM options) - #67321 (make htons const fn) - #67351 (Set release channel on non-dist builders) - #67382 (Remove some unnecessary `ATTR_*` constants.) Failed merges: r? @ghost
Mark-Simulacrum
commented
Dec 18, 2019
MemberAuthor
@bors r- Looks like this failed in https://rust-lang.github.io/rust-log-analyzer/log-viewer/#https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/16178/logs/1654 -- |
Mark-Simulacrumforce-pushed
the
always-channel
branch
from
December 19, 2019 00:52
f365dbc to
8042f50CompareMark-Simulacrum
commented
Dec 19, 2019
MemberAuthor
@bors r=pietroalbini |
bors
commented
Dec 19, 2019
Collaborator
📌 Commit 8042f503bec2dc82a23125d962583918df9d3a13 has been approved by |
bors
commented
Dec 19, 2019
Collaborator
⌛ Testing commit cbd1e73 with merge 4de4d3834c1b48a35a5cd44f195fec9a107ee9bb... |
bors
commented
Dec 19, 2019
Collaborator
💔 Test failed - checks-azure |
Mark-Simulacrum
commented
Dec 19, 2019
MemberAuthor
@bors retry |
Centril added a commit
to Centril/rust
that referenced
this pull request
Dec 19, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
bors
commented
Dec 19, 2019
Collaborator
⌛ Testing commit cbd1e73 with merge b209eaaf1c313af9320a4b5fc561cbaa4018b492... |
Centril
commented
Dec 19, 2019
Contributor
@bors retry rolled up. |
Centril
commented
Dec 19, 2019
Contributor
@bors p=95 |
rust-highfive
commented
Dec 19, 2019
Contributor
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 19, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 19, 2019
…ietroalbini Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
bors added a commit
that referenced
this pull request
Dec 19, 2019
Rollup of 6 pull requests Successful merges: - #67253 (Add more delegations to the fmt docs and add doctests) - #67281 (add string.insert benchmarks) - #67351 (Set release channel on non-dist builders) - #67421 (Fix internal documentation typo) - #67432 (Fix toolstate history format) - #67436 (Correct the todo! stabilization version) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolstate publication only runs if the channel is "nightly" and
previously the toolstate builders did not know that the channel was
nightly (since they are not dist builders).
A look through bootstrap seems to indicate that nothing should directly
depend on the channel being set to
-devon the test builders, thoughthis may cause some problems with UI tests (if for some reason they're
dumping the channel into stderr), but we cannot find evidence of such so
hopefully this is fine.
r? @pietroalbini