4 thread parallelism by default by Mark-Simulacrum · Pull Request #67362 · rust-lang/rust

Mark-Simulacrum · 2019-12-16T21:32:49Z

The Session default here is super unusual but seems to both compile and do what we expect as best as I can tell.

Mark-Simulacrum · 2019-12-16T21:32:56Z

cc https://internals.rust-lang.org/t/plan-to-test-parallel-rustc/11487

rust-highfive · 2019-12-16T22:41:33Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-16T21:33:39.6166042Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-16T21:33:39.6375443Z ##[command]git config gc.auto 0
2019-12-16T21:33:39.6433604Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-16T21:33:39.6489412Z ##[command]git config --get-all http.proxy
2019-12-16T21:33:39.6597272Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67362/merge:refs/remotes/pull/67362/merge
---
2019-12-16T22:30:42.9800836Z .................................................................................................... 1600/9380
2019-12-16T22:30:47.7986676Z .................................................................................................... 1700/9380
2019-12-16T22:30:59.8754396Z ...................................................................i................................ 1800/9380
2019-12-16T22:31:07.1872533Z .................................................................................................... 1900/9380
2019-12-16T22:31:21.3958210Z ....................................................iiiii........................................... 2000/9380
2019-12-16T22:31:31.9075376Z .................................................................................................... 2200/9380
2019-12-16T22:31:34.4123795Z .................................................................................................... 2300/9380
2019-12-16T22:31:37.6550223Z .................................................................................................... 2400/9380
2019-12-16T22:31:58.0546291Z .................................................................................................... 2500/9380
---
2019-12-16T22:34:28.9863511Z .............................................................i...............i...................... 4800/9380
2019-12-16T22:34:36.1268611Z .................................................................................................... 4900/9380
2019-12-16T22:34:43.5270134Z .................................................................................................... 5000/9380
2019-12-16T22:34:48.3500925Z .....i.............................................................................................. 5100/9380
2019-12-16T22:34:57.9761116Z .......................................................................ii.ii...........i............ 5200/9380
2019-12-16T22:35:06.3662458Z .......i............................................................................................ 5400/9380
2019-12-16T22:35:15.6974976Z .................................................................................................... 5500/9380
2019-12-16T22:35:22.0908796Z .....................................................i.............................................. 5600/9380
2019-12-16T22:35:28.7070847Z .................................................................................................... 5700/9380
2019-12-16T22:35:28.7070847Z .................................................................................................... 5700/9380
2019-12-16T22:35:38.0744610Z .................................................................................................... 5800/9380
2019-12-16T22:35:44.9217415Z .........................................ii...i..ii...........i..................................... 5900/9380
2019-12-16T22:36:06.8144496Z .................................................................................................... 6100/9380
2019-12-16T22:36:14.4566570Z .................................................................................................... 6200/9380
2019-12-16T22:36:14.4566570Z .................................................................................................... 6200/9380
2019-12-16T22:36:20.1037123Z ..................................................................i..ii............................. 6300/9380
2019-12-16T22:36:46.1598183Z .................................................................................................... 6500/9380
2019-12-16T22:36:48.3207817Z ......................................i............................................................. 6600/9380
2019-12-16T22:36:50.5212930Z .................................................................................................... 6700/9380
2019-12-16T22:36:52.9491418Z ..............................i..................................................................... 6800/9380
---
2019-12-16T22:38:23.0366767Z .................................................................................................... 7400/9380
2019-12-16T22:38:28.0295826Z .................................................................................................... 7500/9380
2019-12-16T22:38:33.4179077Z .................................................................................................... 7600/9380
2019-12-16T22:38:42.0134562Z .................................................................................................... 7700/9380
2019-12-16T22:38:50.5551006Z ...................................................iiii............................................. 7800/9380
2019-12-16T22:39:04.7404867Z .................................................................................................... 8000/9380
2019-12-16T22:39:10.6887733Z .................................................................................................... 8100/9380
2019-12-16T22:39:25.5554951Z .................................................................................................... 8200/9380
2019-12-16T22:39:33.5510638Z .................................................................................................... 8300/9380
---
2019-12-16T22:41:26.8452735Z ---- [ui] ui/traits/cycle-cache-err-60010.rs stdout ----
2019-12-16T22:41:26.8453006Z diff of stderr:
2019-12-16T22:41:26.8454628Z 2019-12-16T22:41:26.8454714Z 6 |
2019-12-16T22:41:26.8454769Z 7 = note: required because of the requirements on the impl of `Query<RootDatabase>` for `ParseQuery`
2019-12-16T22:41:26.8454820Z 8 2019-12-16T22:41:26.8455270Z - error[E0275]: overflow evaluating the requirement `Runtime<RootDatabase>: std::panic::RefUnwindSafe`
2019-12-16T22:41:26.8455512Z - --> $DIR/cycle-cache-err-60010.rs:31:5
2019-12-16T22:41:26.8456352Z - LL | type Storage;
2019-12-16T22:41:26.8456788Z - | ------- associated type defined here
2019-12-16T22:41:26.8457119Z - ...
2019-12-16T22:41:26.8457119Z - ...
2019-12-16T22:41:26.8457330Z - LL | impl Database for RootDatabase {
2019-12-16T22:41:26.8457777Z - | ------------------------------ in this `impl` item
2019-12-16T22:41:26.8457976Z - LL | type Storage = SalsaStorage;
2019-12-16T22:41:26.8460597Z - |
2019-12-16T22:41:26.8460597Z - |
2019-12-16T22:41:26.8460950Z - = note: required because it appears within the type `RootDatabase`
2019-12-16T22:41:26.8461223Z - = note: required because of the requirements on the impl of `SourceDatabase` for `RootDatabase`
2019-12-16T22:41:26.8461467Z - = note: required because of the requirements on the impl of `Query<RootDatabase>` for `ParseQuery`
2019-12-16T22:41:26.8461683Z - = note: required because it appears within the type `SalsaStorage`
2019-12-16T22:41:26.8462064Z - error: aborting due to 2 previous errors
2019-12-16T22:41:26.8462275Z + error: aborting due to previous error
2019-12-16T22:41:26.8462344Z 26 2019-12-16T22:41:26.8462599Z 27 For more information about this error, try `rustc --explain E0275`.
2019-12-16T22:41:26.8462599Z 27 For more information about this error, try `rustc --explain E0275`.
2019-12-16T22:41:26.8462642Z 28 2019-12-16T22:41:26.8462668Z 2019-12-16T22:41:26.8462708Z 2019-12-16T22:41:26.8462748Z The actual stderr differed from the expected stderr.
2019-12-16T22:41:26.8463028Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010/cycle-cache-err-60010.stderr
2019-12-16T22:41:26.8463267Z To update references, rerun the tests and pass the `--bless` flag
2019-12-16T22:41:26.8463508Z To only update this specific test, also pass `--test-args traits/cycle-cache-err-60010.rs`
2019-12-16T22:41:26.8463577Z error: 1 errors occurred comparing output.
2019-12-16T22:41:26.8463634Z status: exit code: 1
2019-12-16T22:41:26.8463634Z status: exit code: 1
2019-12-16T22:41:26.8464333Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/cycle-cache-err-60010.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010/auxiliary" "-A" "unused"
2019-12-16T22:41:26.8464750Z ------------------------------------------
2019-12-16T22:41:26.8464781Z 2019-12-16T22:41:26.8464986Z ------------------------------------------
2019-12-16T22:41:26.8465025Z stderr:
2019-12-16T22:41:26.8465025Z stderr:
2019-12-16T22:41:26.8465210Z ------------------------------------------
2019-12-16T22:41:26.8465274Z error[E0275]: overflow evaluating the requirement `RootDatabase: SourceDatabase`
2019-12-16T22:41:26.8465490Z --> /checkout/src/test/ui/traits/cycle-cache-err-60010.rs:27:5
2019-12-16T22:41:26.8465544Z |
2019-12-16T22:41:26.8465611Z LL | _parse: <ParseQuery as Query<RootDatabase>>::Data, //~ ERROR overflow
2019-12-16T22:41:26.8465696Z |
2019-12-16T22:41:26.8465696Z |
2019-12-16T22:41:26.8465757Z = note: required because of the requirements on the impl of `Query<RootDatabase>` for `ParseQuery`
2019-12-16T22:41:26.8465824Z error: aborting due to previous error
2019-12-16T22:41:26.8465848Z 2019-12-16T22:41:26.8466082Z For more information about this error, try `rustc --explain E0275`.
2019-12-16T22:41:26.8466112Z ---
2019-12-16T22:41:26.8505905Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-16T22:41:26.8506390Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-16T22:41:26.8520257Z 2019-12-16T22:41:26.8520659Z 2019-12-16T22:41:26.8522431Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-16T22:41:26.8522925Z 2019-12-16T22:41:26.8523039Z 2019-12-16T22:41:26.8570357Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-16T22:41:26.8570873Z Build completed unsuccessfully in 1:01:47
2019-12-16T22:41:26.8570873Z Build completed unsuccessfully in 1:01:47
2019-12-16T22:41:26.8582362Z == clock drift check ==
2019-12-16T22:41:26.8595834Z local time: Mon Dec 16 22:41:26 UTC 2019
2019-12-16T22:41:27.1302458Z network time: Mon, 16 Dec 2019 22:41:27 GMT
2019-12-16T22:41:27.1307869Z == end clock drift check ==
2019-12-16T22:41:28.4327172Z 2019-12-16T22:41:28.4387033Z ##[error]Bash exited with code '1'.
2019-12-16T22:41:28.4427609Z ##[section]Starting: Checkout
2019-12-16T22:41:28.4429163Z ==============================================================================
2019-12-16T22:41:28.4429210Z Task : Get sources
2019-12-16T22:41:28.4429266Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-12-16T22:58:48Z

Heh looks like one of our tests may be a little different in parallel mode!

In any case r=me for tomorrow with tests passing

ehuss · 2019-12-16T23:22:39Z

Maybe update the comment since it still mentions the default is 1?

This avoids the problems of high thread counts (i.e., contention in the kernel on the jobserver pipe due to thundering herd of readers) while stil giving rustc some parallelism to work with.

Mark-Simulacrum · 2019-12-16T23:34:45Z

I finally understand why I've consistently seen that test fail for the last couple beta backports locally and just not understood how that can possibly be the case.

Hopefully patched the test but I'll check again before I go to sleep... let's hope it deterministically fails, at least -- if not, I'll just delete it for now.

rust-highfive · 2019-12-17T00:44:12Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-16T23:35:09.0316958Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-16T23:35:09.0505166Z ##[command]git config gc.auto 0
2019-12-16T23:35:09.0625092Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-16T23:35:09.0660482Z ##[command]git config --get-all http.proxy
2019-12-16T23:35:09.0825524Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67362/merge:refs/remotes/pull/67362/merge
---
2019-12-17T00:32:57.0800518Z .................................................................................................... 1600/9380
2019-12-17T00:33:01.1027360Z .................................................................................................... 1700/9380
2019-12-17T00:33:12.0136921Z ...................................................................i................................ 1800/9380
2019-12-17T00:33:18.6610089Z .................................................................................................... 1900/9380
2019-12-17T00:33:32.7004137Z ....................................................iiiii........................................... 2000/9380
2019-12-17T00:33:42.4640614Z .................................................................................................... 2200/9380
2019-12-17T00:33:44.7287070Z .................................................................................................... 2300/9380
2019-12-17T00:33:47.7720601Z .................................................................................................... 2400/9380
2019-12-17T00:34:08.6142903Z .................................................................................................... 2500/9380
---
2019-12-17T00:36:39.7819817Z .............................................................i...............i...................... 4800/9380
2019-12-17T00:36:47.2864710Z .................................................................................................... 4900/9380
2019-12-17T00:36:55.5040443Z .................................................................................................... 5000/9380
2019-12-17T00:37:00.5490119Z .....i.............................................................................................. 5100/9380
2019-12-17T00:37:10.5722933Z .......................................................................ii.ii...........i............ 5200/9380
2019-12-17T00:37:19.2294047Z .......i............................................................................................ 5400/9380
2019-12-17T00:37:29.5051311Z .................................................................................................... 5500/9380
2019-12-17T00:37:35.8684062Z .....................................................i.............................................. 5600/9380
2019-12-17T00:37:42.6397235Z .................................................................................................... 5700/9380
2019-12-17T00:37:42.6397235Z .................................................................................................... 5700/9380
2019-12-17T00:37:52.9566637Z .................................................................................................... 5800/9380
2019-12-17T00:37:59.8231618Z .........................................ii...i..ii...........i..................................... 5900/9380
2019-12-17T00:38:22.7779150Z .................................................................................................... 6100/9380
2019-12-17T00:38:31.2607763Z .................................................................................................... 6200/9380
2019-12-17T00:38:31.2607763Z .................................................................................................... 6200/9380
2019-12-17T00:38:38.4547336Z ..................................................................i..ii............................. 6300/9380
2019-12-17T00:39:07.3756728Z .................................................................................................... 6500/9380
2019-12-17T00:39:09.5436968Z ......................................i............................................................. 6600/9380
2019-12-17T00:39:11.8419737Z .................................................................................................... 6700/9380
2019-12-17T00:39:14.4141363Z ..............................i..................................................................... 6800/9380
---
2019-12-17T00:40:53.8634792Z .................................................................................................... 7400/9380
2019-12-17T00:40:58.7052396Z .................................................................................................... 7500/9380
2019-12-17T00:41:04.3866140Z .................................................................................................... 7600/9380
2019-12-17T00:41:13.5309975Z .................................................................................................... 7700/9380
2019-12-17T00:41:22.3482397Z ...................................................iiii............................................. 7800/9380
2019-12-17T00:41:36.9029170Z .................................................................................................... 8000/9380
2019-12-17T00:41:43.1501784Z .................................................................................................... 8100/9380
2019-12-17T00:41:58.6279736Z .................................................................................................... 8200/9380
2019-12-17T00:42:06.4899643Z .................................................................................................... 8300/9380
---
2019-12-17T00:44:04.8281749Z error: /checkout/src/test/ui/traits/cycle-cache-err-60010.rs:31: expected error not found: overflow
2019-12-17T00:44:04.8282023Z 2019-12-17T00:44:04.8282289Z error: 0 unexpected errors found, 1 expected errors not found
2019-12-17T00:44:04.8282527Z status: exit code: 1
2019-12-17T00:44:04.8283935Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/cycle-cache-err-60010.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010/auxiliary" "-A" "unused"
2019-12-17T00:44:04.8284430Z Error {
2019-12-17T00:44:04.8284613Z line_num: 31,
2019-12-17T00:44:04.8284791Z kind: Some(
2019-12-17T00:44:04.8284984Z Error,
---
2019-12-17T00:44:04.8288488Z 2019-12-17T00:44:04.8297932Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-17T00:44:04.8305128Z 2019-12-17T00:44:04.8305267Z 2019-12-17T00:44:04.8309786Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-17T00:44:04.8311009Z 2019-12-17T00:44:04.8312219Z 2019-12-17T00:44:04.8325820Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-17T00:44:04.8326034Z Build completed unsuccessfully in 1:02:53
2019-12-17T00:44:04.8326034Z Build completed unsuccessfully in 1:02:53
2019-12-17T00:44:04.8378473Z == clock drift check ==
2019-12-17T00:44:04.8397739Z local time: Tue Dec 17 00:44:04 UTC 2019
2019-12-17T00:44:05.1244635Z network time: Tue, 17 Dec 2019 00:44:05 GMT
2019-12-17T00:44:05.1249046Z == end clock drift check ==
2019-12-17T00:44:06.0353366Z 2019-12-17T00:44:06.0469220Z ##[error]Bash exited with code '1'.
2019-12-17T00:44:06.0515707Z ##[section]Starting: Checkout
2019-12-17T00:44:06.0517582Z ==============================================================================
2019-12-17T00:44:06.0517643Z Task : Get sources
2019-12-17T00:44:06.0517681Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

This also removes the unused NO_PARALLEL_COMPILER flag; if we want that functionality we can readd it but this makes sure we really are parallel everywhere. This also patches a test that has differing output in the parallel case (hopefully deterministically so!).

Mark-Simulacrum · 2019-12-17T03:09:18Z

Okay, CI is passing here. It is past the UTC deadline for nightlies, and is ~21 hours till the next nightly is scheduled to be 'forked' off. So, @bors r=alexcrichton

This hopefully ensures that we can get it in before the next nightly drops (and while we're at it, get some testing inside Rust's CI as well).

bors · 2019-12-17T03:09:20Z

📌 Commit 47bb760 has been approved by alexcrichton

bors · 2019-12-17T03:09:20Z

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Mark-Simulacrum · 2019-12-17T03:09:34Z

And since we want this urgently @bors p=100

bors · 2019-12-17T03:09:49Z

⌛ Testing commit 47bb760 with merge eb33dd7e8c37024152db49ab4aa429e8b4a0d048...

rust-highfive · 2019-12-17T03:14:28Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-17T03:11:35.2154907Z Chocolatey v0.10.15
2019-12-17T03:12:22.1820500Z Installing the following packages:
2019-12-17T03:12:22.1824791Z msys2
2019-12-17T03:12:22.1829146Z By installing you accept licenses for the packages.
2019-12-17T03:14:02.9845595Z Error retrieving packages from source 'https://chocolatey.org/api/v2/':
2019-12-17T03:14:02.9845923Z Could not connect to the feed specified at 'https://chocolatey.org/api/v2/'. Please verify that the package source (located in the Package Manager Settings) is valid and ensure your network connectivity.
2019-12-17T03:14:02.9854014Z msys2 not installed. The package was not found with the source(s) listed.
2019-12-17T03:14:02.9854140Z Source(s): 'https://chocolatey.org/api/v2/'
2019-12-17T03:14:02.9854281Z NOTE: When you specify explicit sources, it overrides default sources.
2019-12-17T03:14:02.9854405Z If the package version is a prerelease and you didn't specify `--pre`,
2019-12-17T03:14:02.9854596Z Please see https://chocolatey.org/docs/troubleshooting for more 2019-12-17T03:14:02.9854674Z assistance.
2019-12-17T03:14:02.9968383Z 2019-12-17T03:14:02.9968604Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-12-17T03:14:02.9968604Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-12-17T03:14:02.9968701Z See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-12-17T03:14:02.9972859Z 2019-12-17T03:14:02.9976924Z Failures
2019-12-17T03:14:02.9982848Z - msys2 - msys2 not installed. The package was not found with the source(s) listed.
2019-12-17T03:14:02.9983003Z Source(s): 'https://chocolatey.org/api/v2/'
2019-12-17T03:14:02.9983097Z NOTE: When you specify explicit sources, it overrides default sources.
2019-12-17T03:14:02.9983233Z If the package version is a prerelease and you didn't specify `--pre`,
2019-12-17T03:14:02.9983421Z Please see https://chocolatey.org/docs/troubleshooting for more 2019-12-17T03:14:02.9983522Z assistance.
2019-12-17T03:14:02.9997870Z 2019-12-17T03:14:02.9998046Z Did you know the proceeds of Pro (and some proceeds from other
2019-12-17T03:14:02.9998046Z Did you know the proceeds of Pro (and some proceeds from other
2019-12-17T03:14:02.9998142Z licensed editions) go into bettering the community infrastructure?
2019-12-17T03:14:02.9998261Z Your support ensures an active community, keeps Chocolatey tip top,
2019-12-17T03:14:02.9998343Z plus it nets you some awesome features!
2019-12-17T03:14:02.9998455Z https://chocolatey.org/compare
2019-12-17T03:14:03.3702317Z 2019-12-17T03:14:03.3806702Z ##[error]Bash exited with code '1'.
2019-12-17T03:14:03.3934094Z ##[section]Starting: Checkout
2019-12-17T03:14:03.4037815Z ==============================================================================
2019-12-17T03:14:03.4037938Z Task : Get sources
2019-12-17T03:14:03.4038023Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-17T03:14:34Z

💔 Test failed - checks-azure

mati865 · 2019-12-17T09:02:35Z

Chocolatey networking issues...
Can somebody retry it?

Mark-Simulacrum · 2019-12-17T12:34:06Z

@bors retry

bors · 2019-12-17T12:34:19Z

⌛ Testing commit 47bb760 with merge 8753fb06fd9874a1eed1f6b0988e7b24ac5107e5...

rust-highfive · 2019-12-17T17:12:48Z

The job x86_64-gnu-aux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-17T17:10:40.3686343Z 2019-12-17T17:10:40.3686436Z failures:
2019-12-17T17:10:40.3686476Z 2019-12-17T17:10:40.3687262Z ---- build::compiler_json_error_format stdout ----
2019-12-17T17:10:40.3687719Z running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo build -v --message-format=json --jobs=1`
2019-12-17T17:10:40.3688082Z thread 'build::compiler_json_error_format' panicked at '
2019-12-17T17:10:40.3688169Z Expected: execs
2019-12-17T17:10:40.3688275Z but: JSON mismatch
2019-12-17T17:10:40.3688423Z {
2019-12-17T17:10:40.3688498Z "executable": null,
2019-12-17T17:10:40.3688567Z "features": [],
2019-12-17T17:10:40.3688567Z "features": [],
2019-12-17T17:10:40.3688650Z "filenames": "{...}",
2019-12-17T17:10:40.3688719Z "fresh": false,
2019-12-17T17:10:40.3688802Z "package_id": "foo 0.5.0 ([..])",
2019-12-17T17:10:40.3688873Z "profile": {
2019-12-17T17:10:40.3688954Z "debug_assertions": true,
2019-12-17T17:10:40.3689031Z "debuginfo": 2,
2019-12-17T17:10:40.3689112Z "opt_level": "0",
2019-12-17T17:10:40.3689181Z "overflow_checks": true,
2019-12-17T17:10:40.3689268Z "test": false
2019-12-17T17:10:40.3689333Z },
2019-12-17T17:10:40.3689627Z "reason": "compiler-artifact",
2019-12-17T17:10:40.3689702Z "target": {
2019-12-17T17:10:40.3689785Z "crate_types": [
2019-12-17T17:10:40.3689931Z ],
2019-12-17T17:10:40.3689931Z ],
2019-12-17T17:10:40.3690006Z "doctest": false,
2019-12-17T17:10:40.3690225Z "edition": "2015",
2019-12-17T17:10:40.3690308Z "kind": [
2019-12-17T17:10:40.3690588Z "custom-build"
2019-12-17T17:10:40.3690676Z ],
2019-12-17T17:10:40.3690932Z "name": "build-script-build",
2019-12-17T17:10:40.3691021Z "src_path": "[..]build.rs"
2019-12-17T17:10:40.3691090Z }
2019-12-17T17:10:40.3691225Z Was:
2019-12-17T17:10:40.3691299Z {
2019-12-17T17:10:40.3691359Z "message": {
2019-12-17T17:10:40.3691439Z "children": [
---
2019-12-17T17:10:40.3692191Z "code": {
2019-12-17T17:10:40.3692276Z "code": "dead_code",
2019-12-17T17:10:40.3692345Z "explanation": null
2019-12-17T17:10:40.3692425Z },
2019-12-17T17:10:40.3692487Z "level": "warning",
2019-12-17T17:10:40.3692576Z "message": "function is never used: `dead`",
2019-12-17T17:10:40.3693040Z "rendered": "warning: function is never used: `dead`/n --> bar/src/lib.rs:1:4/n |/n1 | fn dead() {}/n | ^^^^/n |/n = note: `#[warn(dead_code)]` on by default/n/n",
2019-12-17T17:10:40.3693174Z "spans": [
2019-12-17T17:10:40.3693329Z "byte_end": 7,
2019-12-17T17:10:40.3693411Z "byte_start": 3,
2019-12-17T17:10:40.3693480Z "column_end": 8,
2019-12-17T17:10:40.3693566Z "column_start": 4,
2019-12-17T17:10:40.3693566Z "column_start": 4,
2019-12-17T17:10:40.3693636Z "expansion": null,
2019-12-17T17:10:40.3693718Z "file_name": "bar/src/lib.rs",
2019-12-17T17:10:40.3693790Z "is_primary": true,
2019-12-17T17:10:40.3693874Z "label": null,
2019-12-17T17:10:40.3694034Z "line_start": 1,
2019-12-17T17:10:40.3694103Z "suggested_replacement": null,
2019-12-17T17:10:40.3694193Z "suggestion_applicability": null,
2019-12-17T17:10:40.3694265Z "text": [
---
2019-12-17T17:10:40.3694734Z }
2019-12-17T17:10:40.3694823Z ]
2019-12-17T17:10:40.3694884Z }
2019-12-17T17:10:40.3694958Z ]
2019-12-17T17:10:40.3695017Z },
2019-12-17T17:10:40.3695473Z "package_id": "bar 0.5.0 (path+file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/cit/t211/foo/bar)",
2019-12-17T17:10:40.3695770Z "reason": "compiler-message",
2019-12-17T17:10:40.3695859Z "target": {
2019-12-17T17:10:40.3695923Z "crate_types": [
2019-12-17T17:10:40.3696016Z "lib"
2019-12-17T17:10:40.3696076Z ],
2019-12-17T17:10:40.3696151Z "doctest": true,
2019-12-17T17:10:40.3696220Z "edition": "2015",
2019-12-17T17:10:40.3696303Z "kind": [
2019-12-17T17:10:40.3696380Z "lib"
2019-12-17T17:10:40.3696516Z "name": "bar",
2019-12-17T17:10:40.3696516Z "name": "bar",
2019-12-17T17:10:40.3696911Z "src_path": "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/cit/t211/foo/bar/src/lib.rs"
2019-12-17T17:10:40.3697039Z }
2019-12-17T17:10:40.3697173Z Expected part:
2019-12-17T17:10:40.3697237Z {
2019-12-17T17:10:40.3697312Z "executable": null,
2019-12-17T17:10:40.3697380Z "features": [],
2019-12-17T17:10:40.3697380Z "features": [],
2019-12-17T17:10:40.3697461Z "filenames": "{...}",
2019-12-17T17:10:40.3697529Z "fresh": false,
2019-12-17T17:10:40.3697613Z "package_id": "foo 0.5.0 ([..])",
2019-12-17T17:10:40.3697684Z "profile": {
2019-12-17T17:10:40.3697764Z "debug_assertions": true,
2019-12-17T17:10:40.3697834Z "debuginfo": 2,
2019-12-17T17:10:40.3698014Z "opt_level": "0",
2019-12-17T17:10:40.3698098Z "overflow_checks": true,
2019-12-17T17:10:40.3698169Z "test": false
2019-12-17T17:10:40.3698248Z },
2019-12-17T17:10:40.3698597Z "reason": "compiler-artifact",
2019-12-17T17:10:40.3698688Z "target": {
2019-12-17T17:10:40.3698752Z "crate_types": [
2019-12-17T17:10:40.3699257Z ],
2019-12-17T17:10:40.3699257Z ],
2019-12-17T17:10:40.3699350Z "doctest": false,
2019-12-17T17:10:40.3699448Z "edition": "2015",
2019-12-17T17:10:40.3699517Z "kind": [
2019-12-17T17:10:40.3699842Z "custom-build"
2019-12-17T17:10:40.3699914Z ],
2019-12-17T17:10:40.3700177Z "name": "build-script-build",
2019-12-17T17:10:40.3700253Z "src_path": "[..]build.rs"
2019-12-17T17:10:40.3700338Z }
2019-12-17T17:10:40.3700474Z Actual part:
2019-12-17T17:10:40.3700536Z {
2019-12-17T17:10:40.3700613Z "message": {
2019-12-17T17:10:40.3700678Z "children": [
---
2019-12-17T17:10:40.3701450Z "code": {
2019-12-17T17:10:40.3701524Z "code": "dead_code",
2019-12-17T17:10:40.3701606Z "explanation": null
2019-12-17T17:10:40.3701674Z },
2019-12-17T17:10:40.3701747Z "level": "warning",
2019-12-17T17:10:40.3701823Z "message": "function is never used: `dead`",
2019-12-17T17:10:40.3702293Z "rendered": "warning: function is never used: `dead`/n --> bar/src/lib.rs:1:4/n |/n1 | fn dead() {}/n | ^^^^/n |/n = note: `#[warn(dead_code)]` on by default/n/n",
2019-12-17T17:10:40.3702412Z "spans": [
2019-12-17T17:10:40.3702564Z "byte_end": 7,
2019-12-17T17:10:40.3702650Z "byte_start": 3,
2019-12-17T17:10:40.3702734Z "column_end": 8,
2019-12-17T17:10:40.3702804Z "column_start": 4,
2019-12-17T17:10:40.3702804Z "column_start": 4,
2019-12-17T17:10:40.3702888Z "expansion": null,
2019-12-17T17:10:40.3702958Z "file_name": "bar/src/lib.rs",
2019-12-17T17:10:40.3703044Z "is_primary": true,
2019-12-17T17:10:40.3703113Z "label": null,
2019-12-17T17:10:40.3703396Z "line_start": 1,
2019-12-17T17:10:40.3703482Z "suggested_replacement": null,
2019-12-17T17:10:40.3703556Z "suggestion_applicability": null,
2019-12-17T17:10:40.3703643Z "text": [
---
2019-12-17T17:10:40.3704038Z }
2019-12-17T17:10:40.3704100Z ]
2019-12-17T17:10:40.3704178Z }
2019-12-17T17:10:40.3704238Z ]
2019-12-17T17:10:40.3704311Z },
2019-12-17T17:10:40.3704751Z "package_id": "bar 0.5.0 (path+file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/cit/t211/foo/bar)",
2019-12-17T17:10:40.3705061Z "reason": "compiler-message",
2019-12-17T17:10:40.3705134Z "target": {
2019-12-17T17:10:40.3705214Z "crate_types": [
2019-12-17T17:10:40.3705292Z "lib"
2019-12-17T17:10:40.3705369Z ],
2019-12-17T17:10:40.3705430Z "doctest": true,
2019-12-17T17:10:40.3705512Z "edition": "2015",
2019-12-17T17:10:40.3705580Z "kind": [
2019-12-17T17:10:40.3705656Z "lib"
2019-12-17T17:10:40.3705793Z "name": "bar",
2019-12-17T17:10:40.3705793Z "name": "bar",
2019-12-17T17:10:40.3706199Z "src_path": "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/cit/t211/foo/bar/src/lib.rs"
2019-12-17T17:10:40.3706405Z }
2019-12-17T17:10:40.3706796Z ', src/tools/cargo/crates/cargo-test-support/src/lib.rs:849:13
2019-12-17T17:10:40.3706910Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-17T17:10:40.3706973Z 2019-12-17T17:10:40.3707011Z ---
2019-12-17T17:10:40.3751658Z 2019-12-17T17:10:40.3751697Z 2019-12-17T17:10:40.3764229Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/tools/cargo src/tools/cargotest
2019-12-17T17:10:40.3764395Z Build completed unsuccessfully in 1:48:08
2019-12-17T17:10:40.3813777Z Makefile:50: recipe for target 'check-aux' failed
2019-12-17T17:10:40.3814063Z make: *** [check-aux] Error 1
2019-12-17T17:10:40.3834304Z local time: Tue Dec 17 17:10:40 UTC 2019
2019-12-17T17:10:40.9071078Z network time: Tue, 17 Dec 2019 17:10:40 GMT
2019-12-17T17:10:40.9071965Z == end clock drift check ==
2019-12-17T17:10:46.6011992Z 2019-12-17T17:10:46.6011992Z 2019-12-17T17:10:46.6113634Z ##[error]Bash exited with code '2'.
2019-12-17T17:10:46.6170287Z ##[section]Starting: Checkout
2019-12-17T17:10:46.6172330Z ==============================================================================
2019-12-17T17:10:46.6172421Z Task : Get sources
2019-12-17T17:10:46.6172519Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-17T17:12:52Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2019-12-17T17:20:05Z

Hm, so this failure might be spurious (i.e., timing dependent). @alexcrichton -- perhaps you've seen this before?

Specifically, it looks like this test expects the build script to build first, but (maybe) with a parallel compiler we're not seeing that happen. I suspect that might be because we're capturing all the jobserver tokens pretty quickly so the build script rustc might not be able to start more than one codegen thread (i.e., the main thread) and as such is waiting on the bar crate to finish.

I've kicked off a build locally of this branch with src/tools/cargo as the test target to hopefully dig in a bit deeper and am going to cede CI time to another PR for now.

Mark-Simulacrum · 2019-12-17T17:24:23Z

@bors retry

If the other PR (beta promotion) fails let's make sure this gets testing right away since it might just pass.

alexcrichton · 2019-12-17T17:34:53Z

Yes that looks like a racy test in Cargo, we likely need to fix that

ehuss · 2019-12-17T17:43:11Z

I'm a bit surprised, because it uses --jobs 1 to ensure the steps are done serially, and cargo should be sorting the dependencies so that it is deterministic.

Is it possible that the job server is getting confused with --jobs 1? Is rustc maybe releasing too many tokens (similar to the cc issue described in rust-lang/cargo#7689)?

Mark-Simulacrum · 2019-12-17T17:49:37Z

Yes, it's a known bug (that we should probably file an issue for) that rustc in parallel mode currently releases its implicit token; we have a fix planned but haven't yet gotten around to implementing it yet.

In discussion with @alexcrichton we concluded that it probably makes sense to just disable Cargo's tests since those are likely inherently racy with this bug for now (we can revert this once we get a nightly out).

@bors r=alexcrichton

bors · 2019-12-17T17:49:39Z

📌 Commit 8858851df08c3cbf657c9c2998af47e2a743d4c2 has been approved by alexcrichton

bors · 2019-12-17T17:53:16Z

⌛ Testing commit 8858851df08c3cbf657c9c2998af47e2a743d4c2 with merge 1805a917b2fbdfd02a156aa93d63ef652ce4487c...

rust-highfive · 2019-12-17T17:53:45Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-17T17:49:00.5347971Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-17T17:49:01.1190578Z ##[command]git config gc.auto 0
2019-12-17T17:49:01.1195094Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-17T17:49:01.1197393Z ##[command]git config --get-all http.proxy
2019-12-17T17:49:01.1202653Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67362/merge:refs/remotes/pull/67362/merge
---
2019-12-17T17:53:21.5769400Z local time: Tue Dec 17 17:53:21 UTC 2019
2019-12-17T17:53:21.6786343Z network time: Tue, 17 Dec 2019 17:53:21 GMT
2019-12-17T17:53:21.6788272Z == end clock drift check ==
2019-12-17T17:53:24.5965426Z 2019-12-17T17:53:24.6068780Z ##[error]Bash exited with code '1'.
2019-12-17T17:53:24.6097720Z ##[section]Starting: Checkout
2019-12-17T17:53:24.6099334Z ==============================================================================
2019-12-17T17:53:24.6099413Z Task : Get sources
2019-12-17T17:53:24.6099461Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

These depend on rustc being bug-free and it looks like that's not currently entirely the case (e.g., we know of at least one bug that introduces nondeterminism).

Mark-Simulacrum · 2019-12-17T17:56:06Z

@bors r=alexcrichton

bors · 2019-12-17T17:56:08Z

📌 Commit 5d4e59b has been approved by alexcrichton

bors · 2019-12-17T17:56:18Z

⌛ Testing commit 5d4e59b with merge 3ed3b8b...

4 thread parallelism by default The Session default here is super unusual but seems to both compile and do what we expect as best as I can tell.

bors · 2019-12-17T21:21:28Z

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 3ed3b8b to master...

…, r=alexcrichton" This reverts commit 3ed3b8b, reversing changes made to 99b8953. We will reland a similar patch at a future date but for now we should get a nightly released in a few hours with the parallel patch, so this should be reverted to make sure that the next nightly is not parallel-enabled.

rust-highfive assigned alexcrichton Dec 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2019

ehuss reviewed Dec 16, 2019
View reviewed changes

Comment threadsrc/librustc_session/config.rs Outdated
ehussDec 16, 2019
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update the comment since it still mentions the default is 1?

Change the default thread count to min(4, vCPUs)
f6281e8
This avoids the problems of high thread counts (i.e., contention in the kernel on the jobserver pipe due to thundering herd of readers) while stil giving rustc some parallelism to work with.

Mark-Simulacrum force-pushed the par-4-default branch from bdad80d to 6475be0Compare December 16, 2019 23:34

Mark-Simulacrum force-pushed the par-4-default branch from 6475be0 to 47bb760Compare December 17, 2019 00:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2019

Disable cargo tests for now
5d4e59b
These depend on rustc being bug-free and it looks like that's not currently entirely the case (e.g., we know of at least one bug that introduces nondeterminism).

Mark-Simulacrum force-pushed the par-4-default branch from 8858851 to 5d4e59bCompare December 17, 2019 17:56

bors added a commit that referenced this pull request Dec 17, 2019
Auto merge of#67362- Mark-Simulacrum:par-4-default, r=alexcrichton
3ed3b8b
4 thread parallelism by default The Session default here is super unusual but seems to both compile and do what we expect as best as I can tell.

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2019

bors merged commit 5d4e59b into rust-lang:masterDec 17, 2019

This was referenced Dec 17, 2019
[WIP] Use a sharded dep node to dep node index map #61845
Closed
Move command line option definitions into a dedicated file #67367
Merged

Mark-Simulacrum deleted the par-4-default branch December 17, 2019 21:25

jackh726 mentioned this pull request May 1, 2020
Remove leftover chalk types #71758
Merged

Uh oh!

Uh oh!

Conversation

Mark-Simulacrum commented Dec 16, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum commented Dec 16, 2019

Uh oh!

rust-highfive commented Dec 16, 2019

Uh oh!

alexcrichton commented Dec 16, 2019

Uh oh!

ehussDec 16, 2019

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Dec 16, 2019

Uh oh!

rust-highfive commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

rust-highfive commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

mati865 commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

rust-highfive commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

alexcrichton commented Dec 17, 2019

Uh oh!

ehuss commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

rust-highfive commented Dec 17, 2019

Uh oh!

Mark-Simulacrum commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

bors commented Dec 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mark-Simulacrum commented Dec 16, 2019•
edited
Loading