Skip to content

Warn against relying on ?Sized being last - #67504

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:note-data-offset
Dec 22, 2019
Merged

Warn against relying on ?Sized being last#67504
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:note-data-offset

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Dec 22, 2019

Copy link
Copy Markdown
Member

Fixes#62522

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2019
@Centril

Copy link
Copy Markdown
Contributor

💖

@bors r+ rollup

@bors

bors commented Dec 22, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a34c267 has been approved by Centril

@bors

bors commented Dec 22, 2019

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2019
…=Centril
Warn against relying on ?Sized being last
Fixesrust-lang#62522
@CentrilCentril mentioned this pull request Dec 22, 2019
bors added a commit that referenced this pull request Dec 22, 2019
Rollup of 6 pull requests
Successful merges:
- #67148 ( Refactor type & bounds parsing thoroughly)
- #67410 (Reenable static linking of libstdc++ on windows-gnu)
- #67439 (Cleanup `lower_pattern_unadjusted` & Improve slice pat typeck)
- #67480 (Require issue = "none" over issue = "0" in unstable attributes)
- #67500 (Tweak non_shorthand_field_patterns' suggestion)
- #67504 (Warn against relying on ?Sized being last)
Failed merges:
r? @ghost
@bors
bors merged commit a34c267 into rust-lang:masterDec 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is Rc’s and Arc’s data_offset correct?

4 participants

@Mark-Simulacrum@Centril@bors@rust-highfive