Uh oh!
There was an error while loading. Please reload this page.
test the unleashed Miri - #67580
Conversation
| use std::sync::atomic::Ordering; | ||
| const BOO: &usize = { //~ ERROR undefined behavior to use this value | ||
| const REF_INTERIOR_MUT: &usize = { //~ ERROR undefined behavior to use this value |
There was a problem hiding this comment.
You don't like my useless variable names? 🙃
If we'd had the _ name feature back when I wrote the test I'dve used that
There was a problem hiding this comment.
I'd argue readable names are better even than _ ;)
| }; | ||
| // Make sure we catch executing bad drop functions. | ||
| // The actual error is located in `real_drop_in_place` so we can't capture it with the |
There was a problem hiding this comment.
you can use error-pattern on the file or whatever that comment tag is called.
But in general I think it would be useful to have //~ LABEL annotations that just check for any sub-span on an error
There was a problem hiding this comment.
But in general I think it would be useful to have //~ LABEL annotations that just check for any sub-span on an error
That would be a new compiletest feature, right, nothing I can do now?
There was a problem hiding this comment.
yea it was just random musings
RalfJung
commented
Dec 25, 2019
@oli-obk I think I addressed all comments. |
oli-obk
commented
Dec 25, 2019
@bors r+ |
bors
commented
Dec 25, 2019
📌 Commit 40b8b7c has been approved by |
bors
commented
Dec 26, 2019
test the unleashed Miri In particular, test what happens when we try to drop something. Cc rust-lang/const-eval#17 r? @oli-obk
bors
commented
Dec 26, 2019
☀️ Test successful - checks-azure |
In particular, test what happens when we try to drop something. Cc rust-lang/const-eval#17
r? @oli-obk