Skip to content

Add Scalar::to_(u|i)16 methods - #67604

Merged
bors merged 2 commits into
rust-lang:masterfrom
pvdrz:scalar_to_(u|i)64
Dec 28, 2019
Merged

Add Scalar::to_(u|i)16 methods#67604
bors merged 2 commits into
rust-lang:masterfrom
pvdrz:scalar_to_(u|i)64

Conversation

@pvdrz

@pvdrzpvdrz commented Dec 25, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 25, 2019
RalfJung
RalfJung reviewed Dec 25, 2019
View reviewed changes
Comment threadsrc/librustc/mir/interpret/value.rs Outdated
Centril
Centril reviewed Dec 25, 2019
View reviewed changes
Comment threadsrc/librustc/mir/interpret/value.rs
Centril
Centril reviewed Dec 25, 2019
View reviewed changes
Comment threadsrc/librustc/mir/interpret/value.rs
RalfJung
RalfJung reviewed Dec 25, 2019
View reviewed changes
Comment threadsrc/librustc/mir/interpret/value.rs Outdated
RalfJung
RalfJung reviewed Dec 25, 2019
View reviewed changes
Comment threadsrc/librustc/mir/interpret/value.rs Outdated
@RalfJung

RalfJung commented Dec 25, 2019

Copy link
Copy Markdown
Member

LGTM, thanks!

@bors r+

@bors

bors commented Dec 25, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit dfcc44d has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 26, 2019
@JohnTitor
Rollup merge ofrust-lang#67604- christianpoveda:scalar_to_(u|i)64, …
a9528b3
…r=RalfJung
Add Scalar::to_(u|i)16 methods
r? @RalfJung
@JohnTitorJohnTitor mentioned this pull request Dec 26, 2019
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 26, 2019
@JohnTitor
Rollup merge ofrust-lang#67604- christianpoveda:scalar_to_(u|i)64, …
5d69602
…r=RalfJung
Add Scalar::to_(u|i)16 methods
r? @RalfJung
@JohnTitorJohnTitor mentioned this pull request Dec 26, 2019
Closed
bors added a commit that referenced this pull request Dec 26, 2019
@bors
Auto merge of#67626- JohnTitor:rollup-bt8kv3i, r=JohnTitor
7d1b419
Rollup of 6 pull requests
Successful merges:
- #67576 (reuse `capacity` variable in slice::repeat)
- #67598 (Fix ICE / miscompilation when inlining simd shuffle intrinsic in MIR.)
- #67602 (Use issue = "none" instead of "0" in intrinsics)
- #67604 (Add Scalar::to_(u|i)16 methods)
- #67605 (tidy: change msdn links to newer locations)
- #67617 (Remove `compiler_builtins_lib` documentation)
Failed merges:
r? @ghost
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Dec 26, 2019
@Mark-Simulacrum
Rollup merge ofrust-lang#67604- christianpoveda:scalar_to_(u|i)64, …
f121b3f
…r=RalfJung
Add Scalar::to_(u|i)16 methods
r? @RalfJung
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Dec 26, 2019
Closed
oli-obk added a commit to oli-obk/rust that referenced this pull request Dec 27, 2019
@oli-obk
Rollup merge ofrust-lang#67604- christianpoveda:scalar_to_(u|i)64, …
e9af9db
…r=RalfJung
Add Scalar::to_(u|i)16 methods
r? @RalfJung
@oli-obkoli-obk mentioned this pull request Dec 27, 2019
Merged
bors added a commit that referenced this pull request Dec 28, 2019
@bors
Auto merge of#67670- oli-obk:rollup-2dp08sd, r=oli-obk
3a087ad
Rollup of 15 pull requests
Successful merges:
- #65244 (add IntoFuture trait and support for await)
- #67576 (reuse `capacity` variable in slice::repeat)
- #67588 (Use NonNull in slice::Iter and slice::IterMut.)
- #67594 (Update libc to 0.2.66)
- #67602 (Use issue = "none" instead of "0" in intrinsics)
- #67604 (Add Scalar::to_(u|i)16 methods)
- #67617 (Remove `compiler_builtins_lib` documentation)
- #67621 (Use the correct type for static qualifs)
- #67629 (Remove redundant link texts)
- #67632 (Convert collapsed to shortcut reference links)
- #67633 (Update .mailmap)
- #67635 (Document safety of Path casting)
- #67654 (Add regression test for old NLL ICE)
- #67659 (Stabilize the `matches!` macro)
- #67664 (Fix some mailmap entries)
Failed merges:
r? @ghost
@bors
bors merged commit dfcc44d into rust-lang:masterDec 28, 2019
@RalfJung

RalfJung commented Dec 28, 2019

Copy link
Copy Markdown
Member

@christianpoveda can you submit a PR against Miri to use this function and remove the FIXME?

@pvdrz

pvdrz commented Dec 28, 2019

Copy link
Copy Markdown
ContributorAuthor

sure

@pvdrzpvdrz mentioned this pull request Dec 28, 2019
Merged
bors added a commit to rust-lang/miri that referenced this pull request Dec 28, 2019
@bors
Auto merge of#1132- christianpoveda:use_scalar_to_u16, r=RalfJung
60447d3
Use Scalar::to_u16
rust-lang/rust#67604 (comment) r? @RalfJung
bors added a commit to rust-lang/miri that referenced this pull request Dec 28, 2019
@bors
Auto merge of#1132- christianpoveda:use_scalar_to_u16, r=RalfJung
16f5d20
Use Scalar::to_u16
rust-lang/rust#67604 (comment) r? @RalfJung
@pvdrz
pvdrz deleted the scalar_to_(u|i)64 branch November 23, 2021 15:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@RalfJungRalfJung

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pvdrz@RalfJung@bors@Centril@rust-highfive