Fix Instance::resolve() incorrectly returning specialized instances

[wesleywiser]

We only want to return specializations when Reveal::All is passed, not
when Reveal::UserFacing is. Resolving this fixes several issues with
the ConstProp, SimplifyBranches, and Inline MIR optimization
passes.

Fixes#66901

Rebased on top of #67631

r? @oli-obk

[anp]

@oli-obk I assume that closing #67631 implies this should also fix the test failure I have in #67137, but rebasing onto @wesleywiser's branch still yields a failure for me :(.

[wesleywiser]

Force pushed

[wesleywiser]

Hi @anp do you have the error details so I can look at them?

[anp]

It's the same error that highfive reports:

------------------------------------------
stderr:
------------------------------------------
warning: due to multiple output types requested, the explicitly specified output file name will be adapted for each output type
warning: struct is never constructed: `PrintName`
--> /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:10:8
|
10 | struct PrintName<T>(T);
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: associated const is never used: `VOID`
--> /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:13:5
|
13 | const VOID: ! = panic!();
| ^^^^^^^^^^^^^^^^^^^^^^^^^
warning: function is never used: `no_codegen`
--> /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:16:4
|
16 | fn no_codegen<T>() {
| ^^^^^^^^^^
error: any use of this value will cause an error
--> /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:13:21
|
13 | const VOID: ! = panic!();
| ----------------^^^^^^^^-
| |
| the evaluated program panicked at 'explicit panic', /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:13:21
|
= note: `#[deny(const_err)]` on by default
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error[E0080]: erroneous constant used
--> /usr/local/google/home/adamperry/c/rust/src/test/mir-opt/retain-never-const.rs:17:13
|
17 | let _ = PrintName::<T>::VOID;
| ^^^^^^^^^^^^^^^^^^^^ referenced constant has errors
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0080`.
------------------------------------------
failures:
[mir-opt] mir-opt/retain-never-const.rs
test result: FAILED. 73 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

[oli-obk]

I guess we still need my PR for backwards compatibility of @anp's PR. I'll reopen

[wesleywiser]

I have no idea why your PR would change that test's behavior but I wonder if we shouldn't have #[warn(const_err)] on that test.

[anp]

I think oli said at one point that it would be a breaking change to allow const prop to surface this error?

[oli-obk]

error[E0080]: erroneous constant used

this is the problem, the use of the broken constant inside a never used function should not cause a hard error.

[oli-obk]

@bors r+

[bors]

📌 Commit 25a8b5d has been approved by oli-obk

[eddyb]

You might want an assert that !trait_ref.needs_infer().