Resolve long compile times when evaluating always valid constants by wesleywiser · Pull Request #67667 · rust-lang/rust

wesleywiser · 2019-12-27T19:38:38Z

This extends the existing logic which skips validating every integer or
floating point number type to also skip validating empty structs because
they are also trivially valid.

Fixes#67539

r? @oli-obk
cc @RalfJung @spastorino

wesleywiser · 2019-12-28T01:25:24Z

Force pushed

wesleywiser · 2019-12-28T16:34:42Z

Force pushed. We're back to the original version with an added //FIXME to document that we could eventually handle more cases with a more complete analysis.

oli-obk · 2019-12-29T01:17:00Z

+const FOO: [Empty; 3] = [foo(); 3];
+
+#[warn(const_err)]
+const BAR: [Empty; 3] = [unsafe { std::mem::transmute(()) }; 3];


side note: if you remove this constant and its use, you do get a hard error on the use of FOO, but BAR is what we are actually interested in testing here, because it causes validation to error instead of const eval.

oli-obk · 2019-12-29T01:18:08Z

@bors r+

bors · 2019-12-29T01:18:09Z

📌 Commit 31e1c41 has been approved by oli-obk

@oli-obk

…d_constants, r=oli-obk Resolve long compile times when evaluating always valid constants This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixesrust-lang#67539 r? @oli-obk cc @RalfJung @spastorino

JohnTitor · 2019-12-29T20:01:15Z

Seems failed in #67704 (comment)
@bors r-

This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixesrust-lang#67539

wesleywiser · 2019-12-29T21:47:07Z

Ignored 32-bit platforms in the huge-values test I added.

@bors r=oli-obk

bors · 2019-12-29T21:47:09Z

📌 Commit 5ca3a1b has been approved by oli-obk

bors · 2019-12-30T11:31:10Z

⌛ Testing commit 5ca3a1b with merge 0fb4380...

@oli-obk

…, r=oli-obk Resolve long compile times when evaluating always valid constants This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes#67539 r? @oli-obk cc @RalfJung @spastorino

bors · 2019-12-30T14:47:20Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 0fb4380 to master...

Mark-Simulacrum · 2020-02-06T02:50:23Z

Stable nominating per #68873.

pnkfelix · 2020-02-06T15:58:45Z

discussed at T-compiler meeting. stable-accepted.

[stable] 1.41.1 release This backports the following PRs: * Revert "Remove `checked_add` in `Layout::repeat`" #69241 * Do not ICE when encountering `yield` inside `async` block #69175 * Correct ICE caused by macros generating invalid spans. #68611 * Changelog: Demonstrate final build-override syntax #68603 * Resolve long compile times when evaluating always valid constants #67667 * Fix MIR typeck soundness holes #69145 This also includes a commit which rustfmt's files which the latter commits touched (and perhaps a bit more) to make rebasing the PRs go more smoothly (thankfully, this should be the last time we need to do so). I have removed stable-nominated tags from PRs successfully backported.

rust-highfive assigned oli-obk Dec 27, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2019

RalfJung reviewed Dec 27, 2019
View reviewed changes

Comment threadsrc/librustc_mir/interpret/validity.rs Outdated

wesleywiser force-pushed the speed_up_trivially_valid_constants branch from 8a45951 to dce8826Compare December 28, 2019 01:24

wesleywiser force-pushed the speed_up_trivially_valid_constants branch from dce8826 to 19834f3Compare December 28, 2019 01:34

tesuji reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_mir/interpret/validity.rs Outdated
Comment threadsrc/librustc_mir/interpret/validity.rs Outdated

spastorino approved these changes Dec 28, 2019
View reviewed changes

RalfJung reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_mir/interpret/validity.rs Outdated

RalfJung reviewed Dec 28, 2019
View reviewed changes

Comment threadsrc/librustc_mir/interpret/validity.rs Outdated

spastorino mentioned this pull request Dec 28, 2019
Promote references to constants instead of statics #67000
Merged

wesleywiser force-pushed the speed_up_trivially_valid_constants branch from 19834f3 to 31e1c41Compare December 28, 2019 16:33

oli-obk reviewed Dec 29, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019

Dylan-DPC-zz mentioned this pull request Dec 29, 2019
Rollup of 5 pull requests #67704
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2019

Resolve long compile times when evaluating always valid constants
5ca3a1b
This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixesrust-lang#67539

wesleywiser force-pushed the speed_up_trivially_valid_constants branch from 31e1c41 to 5ca3a1bCompare December 29, 2019 21:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 29, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2019

bors merged commit 5ca3a1b into rust-lang:masterDec 30, 2019

Mark-Simulacrum mentioned this pull request Feb 6, 2020
1.41.0: extremely long compile times on some constants #68873
Closed

Mark-Simulacrum added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Feb 6, 2020

Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 6, 2020

pnkfelix added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Feb 6, 2020

Mark-Simulacrum removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Feb 21, 2020

Mark-Simulacrum mentioned this pull request Feb 21, 2020
[stable] 1.41.1 release #69359
Merged

Uh oh!

Uh oh!

Conversation

wesleywiser commented Dec 27, 2019

Uh oh!

Uh oh!

wesleywiser commented Dec 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wesleywiser commented Dec 28, 2019

Uh oh!

oli-obkDec 29, 2019

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Dec 29, 2019

Uh oh!

bors commented Dec 29, 2019

Uh oh!

JohnTitor commented Dec 29, 2019

Uh oh!

wesleywiser commented Dec 29, 2019

Uh oh!

bors commented Dec 29, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

Mark-Simulacrum commented Feb 6, 2020

Uh oh!

pnkfelix commented Feb 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants