Uh oh!
There was an error while loading. Please reload this page.
[const-prop] Remove useless typedef - #67682
Merged
Merged
Conversation
rust-highfive
commented
Dec 28, 2019
Contributor
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
Dylan-DPC-zz
commented
Dec 28, 2019
r? @Dylan-DPC |
Dylan-DPC-zz
commented
Dec 29, 2019
@bors r+ rollup |
bors
commented
Dec 29, 2019
Collaborator
📌 Commit b174aec7c7c32f9d179d613c242668fc8b9cd937 has been approved by |
Dylan-DPC-zz
commented
Dec 29, 2019
Failed in rollup @bors r- |
wesleywiser
commented
Dec 29, 2019
MemberAuthor
There's a few const prop related PRs in flight right now. I'll wait a day or two for those to land and rebase this. |
wesleywiserforce-pushed
the
remove_opty_const_typedef
branch
from
January 4, 2020 13:44
b174aec to
512a7b1Comparewesleywiser
commented
Jan 4, 2020
MemberAuthor
Rebased |
Dylan-DPC-zz
commented
Jan 5, 2020
can you run tidy over this? |
It's confusing because it conflicts with ty::Const and just isn't generally useful.
wesleywiserforce-pushed
the
remove_opty_const_typedef
branch
from
January 18, 2020 23:45
512a7b1 to
a957f0dComparewesleywiser
commented
Jan 18, 2020
MemberAuthor
Rebased and ran tidy |
Dylan-DPC-zz
commented
Jan 19, 2020
@bors r+ rollup |
bors
commented
Jan 19, 2020
Collaborator
📌 Commit a957f0d has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 19, 2020
…ef, r=Dylan-DPC [const-prop] Remove useless typedef It's confusing because it conflicts with `ty::Const` and just isn't generally useful.
bors added a commit
that referenced
this pull request
Jan 19, 2020
Rollup of 5 pull requests Successful merges: - #67682 ([const-prop] Remove useless typedef) - #68133 (Slimmer syntax) - #68154 (Add more BTreeMap/BTreeSet benchmarks regarding iteration) - #68247 (Clean up err codes) - #68348 (Make iter::Empty<T> Send and Sync for any T) Failed merges: - #68353 (Remove `rustc_error_codes` deps except in `rustc_driver`) r? @ghost
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 19, 2020
…ef, r=Dylan-DPC [const-prop] Remove useless typedef It's confusing because it conflicts with `ty::Const` and just isn't generally useful.
bors
commented
Jan 19, 2020
Collaborator
☔ The latest upstream changes (presumably #68363) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's confusing because it conflicts with
ty::Constand just isn'tgenerally useful.