Skip to content

Update rustc-guide - #67689

Merged
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:update-guide
Jan 2, 2020
Merged

Update rustc-guide#67689
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:update-guide

Conversation

@mark-i-m

Copy link
Copy Markdown
Contributor

r? @ehuss

cc @rust-lang/wg-learning

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2019
@JohnTitor

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@bors

bors commented Dec 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 3576737f69d1c542e52ca6ef388638653f192eb1 has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019
@JohnTitor

Copy link
Copy Markdown
Member

r? @JohnTitor

@rust-highfiverust-highfive assigned JohnTitor and unassigned ehussDec 29, 2019
@JohnTitor

Copy link
Copy Markdown
Member

Would you include rust-lang/rustc-dev-guide#549?
@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2020
@mark-i-m

Copy link
Copy Markdown
ContributorAuthor

@JohnTitor Done :)

@JohnTitor

Copy link
Copy Markdown
Member

Thanks!
@bors r+

@bors

bors commented Jan 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 01c93d5 has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 1, 2020
@bors

bors commented Jan 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 01c93d5 with merge 4db1fea95b68101b722f5c494793a1719b298321...

@rust-highfive

Copy link
Copy Markdown
Contributor

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-01T17:06:50.6935669Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-01T17:06:50.7210758Z ##[command]git config gc.auto 0
2020-01-01T17:06:50.7287575Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-01T17:06:50.7350271Z ##[command]git config --get-all http.proxy
2020-01-01T17:06:50.7489530Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67689/merge:refs/remotes/pull/67689/merge
---
2020-01-01T18:43:00.6522220Z Compiling mdbook v0.3.5
2020-01-01T18:43:25.8213795Z Compiling mdbook-linkcheck v0.5.0
2020-01-01T18:43:47.1576520Z Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2020-01-01T18:43:51.5363762Z Finished release [optimized] target(s) in 10m 22s
2020-01-01T18:45:39.0377527Z error: Unable to retrieve "https://perf.wiki.kernel.org/index.php/Main_Page": https://perf.wiki.kernel.org/index.php/Main_Page: timed out
2020-01-01T18:45:39.0378259Z 2020-01-01T18:45:39.0379208Z ┌── profiling/with_perf.md:3:47 ───
2020-01-01T18:45:39.0379665Z │
2020-01-01T18:45:39.0380170Z 3 │ This is a guide for how to profile rustc with [perf](https://perf.wiki.kernel.org/index.php/Main_Page).
2020-01-01T18:45:39.0380851Z │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ https://perf.wiki.kernel.org/index.php/Main_Page: timed out
2020-01-01T18:45:39.0381370Z 2020-01-01T18:45:39.0383772Z Error: One or more incorrect links
2020-01-01T18:45:39.0391105Z 2020-01-01T18:45:39.0391346Z ---
2020-01-01T19:28:52.1661503Z 2020-01-01T19:28:52.1661763Z If you do intend to update 'rustc-guide', please check the error messages above and
2020-01-01T19:28:52.1661810Z commit another update.
2020-01-01T19:28:52.1661834Z 2020-01-01T19:28:52.1662091Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2020-01-01T19:28:52.1662333Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2020-01-01T19:28:52.1662377Z proper steps.
2020-01-01T19:28:52.1662799Z Build completed unsuccessfully in 0:00:01
2020-01-01T19:28:52.1708584Z == clock drift check ==
2020-01-01T19:28:52.1730389Z local time: Wed Jan 1 19:28:52 UTC 2020
2020-01-01T19:28:52.7205802Z network time: Wed, 01 Jan 2020 19:28:52 GMT
2020-01-01T19:28:52.7205802Z network time: Wed, 01 Jan 2020 19:28:52 GMT
2020-01-01T19:28:52.7206584Z == end clock drift check ==
2020-01-01T19:28:53.2365517Z 2020-01-01T19:28:53.2460715Z ##[error]Bash exited with code '1'.
2020-01-01T19:28:53.2499971Z ##[section]Starting: Checkout
2020-01-01T19:28:53.2501471Z ==============================================================================
2020-01-01T19:28:53.2501515Z Task : Get sources
2020-01-01T19:28:53.2501553Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

Copy link
Copy Markdown
Contributor

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-01T20:45:45.2713192Z status: exit code: 2
2020-01-01T20:45:45.2713261Z command: "make" "make"
2020-01-01T20:45:45.2713315Z stdout:
2020-01-01T20:45:45.2713845Z ------------------------------------------
2020-01-01T20:45:45.2714093Z # We don't compile `opaque` with either optimizations or instrumentation.
2020-01-01T20:45:45.2714358Z # We don't compile `opaque` with either optimizations or instrumentation.
2020-01-01T20:45:45.2715136Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights opaque.rs
2020-01-01T20:45:45.2715360Z # Compile the test program with instrumentation
2020-01-01T20:45:45.2715633Z mkdir -p "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir
2020-01-01T20:45:45.2716595Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights interesting.rs \
2020-01-01T20:45:45.2717120Z -Cprofile-generate="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir -O -Ccodegen-units=1
2020-01-01T20:45:45.2718035Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights main.rs -Cprofile-generate="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir -O
2020-01-01T20:45:45.2718299Z # The argument below generates to the expected branch weights
2020-01-01T20:45:45.2719759Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights/main aaaaaaaaaaaa2bbbbbbbbbbbb2bbbbbbbbbbbbbbbbcc || exit 1
2020-01-01T20:45:45.2720495Z "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin"/llvm-profdata merge \
2020-01-01T20:45:45.2720899Z -o "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir/merged.profdata \
2020-01-01T20:45:45.2721299Z "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir
2020-01-01T20:45:45.2722356Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights interesting.rs \
2020-01-01T20:45:45.2723091Z -Cprofile-use="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir/merged.profdata -O \
2020-01-01T20:45:45.2723293Z -Ccodegen-units=1 --emit=llvm-ir
2020-01-01T20:45:45.2723851Z cat "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/interesting.ll | "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" filecheck-patterns.txt
2020-01-01T20:45:45.2724172Z ------------------------------------------
2020-01-01T20:45:45.2724258Z stderr:
2020-01-01T20:45:45.2724462Z ------------------------------------------
2020-01-01T20:45:45.2724462Z ------------------------------------------
2020-01-01T20:45:45.2724715Z filecheck-patterns.txt:5:8: error: CHECK: expected string not found in input
2020-01-01T20:45:45.2724990Z CHECK: define void @function_called_twice(i32 %c) {{.*}} !prof [[function_called_twice_id:![0-9]+]] {
2020-01-01T20:45:45.2725153Z <stdin>:1:1: note: scanning from here
2020-01-01T20:45:45.2725153Z <stdin>:1:1: note: scanning from here
2020-01-01T20:45:45.2725359Z ; ModuleID = 'interesting.3a1fbbbh-cgu.0'
2020-01-01T20:45:45.2725588Z <stdin>:7:1: note: possible intended match here
2020-01-01T20:45:45.2725588Z <stdin>:7:1: note: possible intended match here
2020-01-01T20:45:45.2725670Z define void @function_called_twice(i32 %c) unnamed_addr #0 {
2020-01-01T20:45:45.2725732Z ^
2020-01-01T20:45:45.2725797Z make: *** [Makefile:30: all] Error 1
2020-01-01T20:45:45.2726081Z ------------------------------------------
2020-01-01T20:45:45.2726122Z 2020-01-01T20:45:45.2726150Z 2020-01-01T20:45:45.2726179Z ---
2020-01-01T20:45:45.2727207Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-01T20:45:45.2727299Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-01T20:45:45.2739706Z 2020-01-01T20:45:45.2741761Z 2020-01-01T20:45:45.2749526Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0-rust-1.42.0-nightly\n" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter binaryformat bitreader bitstreamreader bitwriter codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel gtest gtest_main hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target testingsupport textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xray" "--llvm-cxxflags" "-I/checkout/src/llvm-project/llvm/include -I/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/include -std=c++11 -fno-exceptions -fno-rtti -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-01T20:45:45.2751538Z 2020-01-01T20:45:45.2751598Z 2020-01-01T20:45:45.2751672Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-01T20:45:45.2751775Z Build completed unsuccessfully in 2:22:49
2020-01-01T20:45:45.2751775Z Build completed unsuccessfully in 2:22:49
2020-01-01T20:45:45.2892502Z == clock drift check ==
2020-01-01T20:45:45.9332700Z local time: Wed Jan 1 20:45:45 UTC 2020
2020-01-01T20:45:45.9333848Z network time: Wed, 01 Jan 2020 20:45:45 GMT
2020-01-01T20:45:45.9334092Z == end clock drift check ==
2020-01-01T20:45:53.8096137Z 2020-01-01T20:45:53.8223160Z ##[error]Bash exited with code '1'.
2020-01-01T20:45:53.8282909Z ##[section]Starting: Checkout
2020-01-01T20:45:53.8285039Z ==============================================================================
2020-01-01T20:45:53.8285122Z Task : Get sources
2020-01-01T20:45:53.8285213Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

bors commented Jan 1, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2020
@mark-i-m

Copy link
Copy Markdown
ContributorAuthor

Failure looks spurious to me. All except one builder passed, and the one that failed has nothing to do with the guide...

@JohnTitor

Copy link
Copy Markdown
Member

It's a known/filed issue #67746
@bors retry

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 1, 2020
@bors

bors commented Jan 2, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 01c93d5 with merge aaca5f1...

bors added a commit that referenced this pull request Jan 2, 2020
Update rustc-guide
r? @ehuss
cc @rust-lang/wg-learning
@bors

bors commented Jan 2, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: JohnTitor
Pushing aaca5f1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2020
@bors
bors merged commit 01c93d5 into rust-lang:masterJan 2, 2020
@rust-highfive

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #67689!

Tested on commit aaca5f1.
Direct link to PR: #67689

🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 2, 2020
Tested on commit rust-lang/rust@aaca5f1.
Direct link to PR: <rust-lang/rust#67689>
🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra).
@mark-i-m
mark-i-m deleted the update-guide branch March 6, 2020 23:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mark-i-m@rust-highfive@JohnTitor@bors@ehuss