Skip to content

Added dyn and true keyword docs - #67695

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:truth
Feb 12, 2020
Merged

Added dyn and true keyword docs#67695
bors merged 1 commit into
rust-lang:masterfrom
gilescope:truth

Conversation

@gilescope

@gilescopegilescope commented Dec 29, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2019
Dylan-DPC-zz
Dylan-DPC-zz suggested changes Dec 29, 2019
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
petertodd
petertodd reviewed Dec 29, 2019
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
petertodd
petertodd reviewed Dec 29, 2019
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
petertodd
petertodd reviewed Dec 29, 2019
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019
Centril
Centril reviewed Dec 29, 2019
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
@gilescope

gilescope commented Dec 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril is v2 any better? I tried to frame it around dyn Trait versus impl Trait.

1tgr
1tgr reviewed Jan 2, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
1tgr
1tgr reviewed Jan 2, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Centril
Centril reviewed Jan 2, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
Comment threadsrc/libstd/keyword_docs.rs Outdated
@JohnCSimon

JohnCSimon commented Jan 18, 2020

Copy link
Copy Markdown

Ping from triage:
@gilescope please address the change requests. Thanks.

@JohnTitor

JohnTitor commented Feb 2, 2020

Copy link
Copy Markdown
Member

Ping from triage: @gilescope could you address the change requests?

@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope

gilescope commented Feb 9, 2020

Copy link
Copy Markdown
ContributorAuthor

(Sorry for the delay! NixOs and I have been getting to know one another. )
@Centril can you have a look at the impl TraitA for dyn TraitB bit I've added. I want to ensure we get this bit right as it's not documented anywhere else - have I overstepped the mark in saying that object safety does not apply on TraitA? I believe you can have generic methods on TraitA.

@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Feb 10, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Centril
Centril reviewed Feb 10, 2020
View reviewed changes
Comment threadsrc/libstd/keyword_docs.rs Outdated
Giles Cope@Centril
@1tgr@petertodd@Dylan-DPC
Keyword docs
8e26ad0
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Tim Robinson <tim.g.robinson@gmail.com>
Co-Authored-By: Peter Todd <pete@petertodd.org>
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
@gilescope

gilescope commented Feb 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@Centril have squashed commits. Are we good to go?

@Dylan-DPC-zz

Dylan-DPC-zz commented Feb 11, 2020

Copy link
Copy Markdown

@bors r+ rollup

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8e26ad0 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Feb 11, 2020

Copy link
Copy Markdown

@bors r=centril

(Sorry xD)

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8e26ad0 has been approved by centril

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 12, 2020
@Dylan-DPC
Rollup merge ofrust-lang#67695- gilescope:truth, r=centril
c7addfb
Added dyn and true keyword docs
r? @Centril
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 12, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 12, 2020
@JohnTitor
Rollup merge ofrust-lang#67695- gilescope:truth, r=centril
b6a9aa9
Added dyn and true keyword docs
r? @Centril
@JohnTitorJohnTitor mentioned this pull request Feb 12, 2020
Merged
bors added a commit that referenced this pull request Feb 12, 2020
@bors
Auto merge of#69088- JohnTitor:rollup-x7bk7h7, r=JohnTitor
cd5441f
Rollup of 11 pull requests
Successful merges:
- #67695 (Added dyn and true keyword docs)
- #68487 ([experiment] Support linking from a .rlink file)
- #68554 (Split lang_items to crates `rustc_hir` and `rustc_passes`.)
- #68937 (Test failure of unchecked arithmetic intrinsics in const eval)
- #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup)
- #68999 (remove dependency on itertools)
- #69026 (Remove common usage pattern from `AllocRef`)
- #69027 (Add missing `_zeroed` varants to `AllocRef`)
- #69058 (Preparation for allocator aware `Box`)
- #69070 (Add self to .mailmap)
- #69077 (Fix outdated doc comment.)
Failed merges:
r? @ghost
@bors
bors merged commit 8e26ad0 into rust-lang:masterFeb 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@petertoddpetertoddpetertodd left review comments
@1tgr1tgr1tgr left review comments
@CentrilCentrilCentril left review comments
@Dylan-DPC-zzDylan-DPC-zzDylan-DPC-zz requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@gilescope@JohnCSimon@JohnTitor@rust-highfive@Dylan-DPC-zz@bors@petertodd@1tgr@Centril