Uh oh!
There was an error while loading. Please reload this page.
Rename some crates and modules in the frontend - #67707
Merged
Merged
Conversation
petrochenkov
commented
Dec 29, 2019
ContributorAuthor
TODO: Rename |
petrochenkov
commented
Dec 29, 2019
ContributorAuthor
cc @eddyb |
Centril
commented
Dec 29, 2019
Contributor
Ideally that should be done soon tho because the new directory in the filesystem with the old crate name in code becomes confusing. @bors r+ |
bors
commented
Dec 29, 2019
Collaborator
📌 Commit a3eadd0ec1de4d003a5289fe8c830bae86b4c393 has been approved by |
bors
commented
Dec 29, 2019
Collaborator
☔ The latest upstream changes (presumably #67112) made this pull request unmergeable. Please resolve the merge conflicts. |
`syntax_expand` -> `rustc_expand` `syntax_pos` -> `rustc_span` `syntax_ext` -> `rustc_builtin_macros`
petrochenkov
commented
Dec 30, 2019
ContributorAuthor
@bors r=Centril p=1 (conflict-prone) |
bors
commented
Dec 30, 2019
Collaborator
📌 Commit 7608f21 has been approved by |
bors
commented
Dec 30, 2019
Collaborator
bors added a commit
that referenced
this pull request
Dec 30, 2019
Rename some crates and modules in the frontend Migrate from `syntax_*` naming scheme to `rustc_*`. See #65324 (comment) and several comments below. Renamed crates: `syntax_expand` -> `rustc_expand` `syntax_pos` -> `rustc_span` ([motivation](#65324 (comment))) `syntax_ext` -> `rustc_builtin_macros` Also one module in resolve is renamed for consistency and to avoid tautology. r? @Centril
bors
commented
Dec 30, 2019
Collaborator
☀️ Test successful - checks-azure |
This was referenced Dec 30, 2019
JohnTitor added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Dec 31, 2019
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
calebcartwright added a commit
to calebcartwright/rustfmt
that referenced
this pull request
Jan 16, 2020
syntax_pos was renamed to rustc_span rust-lang/rust#67707 and modules like `symbol` and `source_map` are no longer re-exported in libsyanx so we also need to consume them directly from the rustc_span crate rust-lang/rust#67786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
syntax_*naming scheme torustc_*.See #65324 (comment) and several comments below.
Renamed crates:
syntax_expand->rustc_expandsyntax_pos->rustc_span(motivation)syntax_ext->rustc_builtin_macrosAlso one module in resolve is renamed for consistency and to avoid tautology.
r? @Centril