Skip to content

Fix warning for unused variables in or pattern (issue #67691) - #67766

Merged
bors merged 4 commits into
rust-lang:masterfrom
sapir:fix-unused-in-or-pattern-warning
Apr 13, 2020
Merged

Fix warning for unused variables in or pattern (issue #67691)#67766
bors merged 4 commits into
rust-lang:masterfrom
sapir:fix-unused-in-or-pattern-warning

Conversation

@sapir

@sapirsapir commented Jan 1, 2020

Copy link
Copy Markdown
Contributor

Is this a good way to fix it?

Also, the tests fail, the "fixed" code output says { i, j } instead of { i, j: _ }, how can I fix that?

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
Centril
Centril reviewed Jan 1, 2020
View reviewed changes
Comment threadsrc/test/ui/lint/issue-67691-unused-field-in-or-pattern.rs Outdated
@CentrilCentril added the F-or_patterns `#![feature(or_patterns)]` label Jan 1, 2020
@Centril

Centril commented Jan 1, 2020

Copy link
Copy Markdown
Contributor

r? @matthewjasper

@rust-highfive

This comment has been minimized.

Sign in to view
@sapir
sapirforce-pushed the fix-unused-in-or-pattern-warning branch from 2ac7d33 to b88baa1CompareJanuary 3, 2020 11:36
@sapir

sapir commented Jan 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Why aren't the ref keywords being included in the suggestion? The test for #54180 is passing, and afaict the span being passed to multipart_suggestion does include the ref keyword.

@rust-highfive

This comment has been minimized.

Sign in to view
@CentrilCentril added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2020
@bors

This comment has been minimized.

Sign in to view
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 5, 2020
@Centril

This comment has been minimized.

Sign in to view
matthewjasper
matthewjasper reviewed Feb 5, 2020
View reviewed changes
Comment threadsrc/librustc_passes/liveness.rs Outdated
@Centril

This comment has been minimized.

Sign in to view
@sapir

This comment has been minimized.

Sign in to view
@sapir
sapirforce-pushed the fix-unused-in-or-pattern-warning branch 2 times, most recently from c9d7166 to 5f48ad5CompareFebruary 21, 2020 14:49
@rust-highfive

This comment has been minimized.

Sign in to view
matthewjasper
matthewjasper reviewed Mar 1, 2020
View reviewed changes
Comment threadsrc/test/ui/lint/issue-67691-unused-field-in-or-pattern.stderr Outdated
@sapir
sapirforce-pushed the fix-unused-in-or-pattern-warning branch from 5f48ad5 to 44489cfCompareMarch 6, 2020 08:12
@rust-highfive

This comment has been minimized.

Sign in to view
@sapir
sapirforce-pushed the fix-unused-in-or-pattern-warning branch from 44489cf to d43f3d6CompareMarch 7, 2020 20:38
@sapir

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@joelpalmer

joelpalmer commented Mar 23, 2020

Copy link
Copy Markdown

Ping from Triage: Any updates @sapir?

@bors

This comment has been minimized.

Sign in to view
@sapir

sapir commented Mar 24, 2020

Copy link
Copy Markdown
ContributorAuthor

@joelpalmer I don't know what I should do about the multipart suggestions?

@matthewjasper

matthewjasper commented Mar 28, 2020

Copy link
Copy Markdown
Contributor

multipart_suggestion is correct. You;ll have to remove run-rustfix from the test and leave a FIXME.

@joelpalmerjoelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2020
@joelpalmer

This comment has been minimized.

Sign in to view
@sapir
sapirforce-pushed the fix-unused-in-or-pattern-warning branch from 8d736dd to 3221638CompareApril 10, 2020 02:53
@sapir

sapir commented Apr 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@joelpalmer I did as @matthewjasper suggested regarding multipart_suggestions, so the tests pass now. Also I rebased to current master and fixed some conflicts.

@matthewjasper

matthewjasper commented Apr 12, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 12, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 3221638 has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 12, 2020
@bors

This comment has been minimized.

Sign in to view
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 12, 2020
Merged
@Dylan-DPC-zz

This comment has been minimized.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2020
@bors
Auto merge ofrust-lang#71079- Dylan-DPC:rollup-g7yh3sn, r=Dylan-DPC
9fed360
Rollup of 4 pull requests
Successful merges:
- rust-lang#67766 (Fix warning for unused variables in or pattern (issue rust-lang#67691))
- rust-lang#71013 (Pass the `PlaceElem::Index` local to `visit_local`)
- rust-lang#71064 (fix issue 69130)
- rust-lang#71069 (Remove some usage of `DUMMY_HIR_ID`)
Failed merges:
r? @ghost
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2020
@bors
bors merged commit 6947dec into rust-lang:masterApr 13, 2020
@sapir
sapir deleted the fix-unused-in-or-pattern-warning branch April 13, 2020 01:59
This was referenced Apr 13, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewjaspermatthewjaspermatthewjasper left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@matthewjaspermatthewjasper

Labels

F-or_patterns`#![feature(or_patterns)]`S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sapir@rust-highfive@Centril@bors@joelpalmer@matthewjasper@Dylan-DPC-zz@eddyb