Skip to content

Prevent refcount cycles during linting - #6777

Merged
bors merged 1 commit into
rust-lang:incomingfrom
alexcrichton:less-memory
May 28, 2013
Merged

Prevent refcount cycles during linting#6777
bors merged 1 commit into
rust-lang:incomingfrom
alexcrichton:less-memory

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Via my super-accurate timing (/usr/bin/time -l), I get 2431119360 => 1884430336 == ~520MB

Closes#6637.

Shaves off ~600MB of memory while compiling rustc
@graydon

Copy link
Copy Markdown
Contributor

Thanks, great work. Sorry it's not cycle-proof yet :(

@alexcrichton

Copy link
Copy Markdown
MemberAuthor

No problem! Thanks for helping me debug this

bors added a commit that referenced this pull request May 28, 2013
Via my super-accurate timing (`/usr/bin/time -l`), I get 2431119360 => 1884430336 == ~520MB
Closes#6637.
@borsbors closed this May 28, 2013
@bors
bors merged commit ae7df57 into rust-lang:incomingMay 28, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 25, 2021
…from_doc, r=phansch
Remove unneeded blank lines from doc
Remove unneeded blank lines like below.
<img width="1142" alt="スクリーンショット 2021-02-22 23 01 17" src="https://user-images.githubusercontent.com/17407489/108719295-bb9ff800-7562-11eb-9338-8f2571e61c56.png">
changelog: none
rust-borsBot pushed a commit that referenced this pull request Feb 27, 2026
I kinda confused `review-changes-since` versus `range-diff` :D
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
7602: Check for dyn impls in method resolution r=flodiebold a=Veykril
Fixesrust-lang#6777
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcrichton@graydon@bors