Uh oh!
There was an error while loading. Please reload this page.
Make "use $crate" a hard error - #67775
Conversation
rust-highfive
commented
Jan 1, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Dylan-DPC-zz
commented
Jan 1, 2020
r? @Dylan-DPC |
rust-highfive
commented
Jan 1, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jan 2, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jan 2, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jan 2, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jan 3, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
mental32
commented
Jan 3, 2020
@JohnTitor Thanks! First time contributor here and the UI tests are difficult to get used to, I'm unable to build Rustc so I cant test changes locally, so far its been hit and miss :( |
JohnTitor
commented
Jan 3, 2020
Uhm, applying suggestions on GitHub ignores blank lines, so could you insert them on your local and push it? Anyway, thanks for considering the contributions. |
JohnTitor
commented
Jan 3, 2020
Also, it's good to squash commits into one. |
rust-highfive
commented
Jan 3, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Dylan-DPC-zz
commented
Jan 4, 2020
yaay finally :P @bors r+ rollup |
bors
commented
Jan 4, 2020
📌 Commit c818f4c has been approved by |
Make "use $crate" a hard error Closesrust-lang#37390
Rollup of 4 pull requests Successful merges: - #67137 (libstd uses `core::panic::Location` where possible.) - #67709 (Introduce an option for disabling deduplication of diagnostics) - #67775 (Make "use $crate" a hard error) - #67812 (Tweak and extend internal BTreeMap documentation, including debug asserts.) Failed merges: r? @ghost
Closes#37390