Skip to content

Revert const_err lint checking of casts - #67822

Merged
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:revert_67676
Jan 4, 2020
Merged

Revert const_err lint checking of casts#67822
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:revert_67676

Conversation

@wesleywiser

@wesleywiserwesleywiser commented Jan 3, 2020

Copy link
Copy Markdown
Member

Reverts part of #67676

r? @oli-obk

cc @SimonSapin

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk

oli-obk commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8e4886d has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2020
@RalfJung

RalfJung commented Jan 3, 2020

Copy link
Copy Markdown
Member

@wesleywiser When this lands, can you also submit a PR against Miri to remove the allow(const_err) you added?

@wesleywiser

wesleywiser commented Jan 3, 2020

Copy link
Copy Markdown
MemberAuthor

@RalfJung Yes, I can do that. Depending on when this PR merges, I may already be on vacation so it might be a few days after that before the PR appears.

@sinkuusinkuu mentioned this pull request Jan 3, 2020
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2020
@GuillaumeGomez
Rollup merge ofrust-lang#67822- wesleywiser:revert_67676, r=oli-obk
a469b17
Revert `const_err` lint checking of casts
Reverts part of rust-lang#67676
r? @oli-obk
cc @SimonSapin
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 4, 2020
Merged
bors added a commit that referenced this pull request Jan 4, 2020
@bors
Auto merge of#67866- GuillaumeGomez:rollup-32vsg5b, r=GuillaumeGomez
cd8377d
Rollup of 4 pull requests
Successful merges:
- #67822 (Revert `const_err` lint checking of casts)
- #67823 (improve some `Drop`-related error messages)
- #67837 (Clean up err codes)
- #67848 (Remove unused `#[link_name = "m"]` attributes)
Failed merges:
r? @ghost
@bors
bors merged commit 8e4886d into rust-lang:masterJan 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleywiser@rust-highfive@oli-obk@bors@RalfJung