Uh oh!
There was an error while loading. Please reload this page.
Silence TooGeneric error - #67906
Merged
Merged
Conversation
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
nagisa
commented
Jan 5, 2020
Member
@bors r+ |
bors
commented
Jan 5, 2020
Collaborator
📌 Commit adb46fd has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 6, 2020
Silence `TooGeneric` error This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later. Fixesrust-lang#66962. r? @eddyb
bors added a commit
that referenced
this pull request
Jan 6, 2020
Rollup of 6 pull requests Successful merges: - #67800 (Fix ICE involving calling `Instance.ty` during const evaluation) - #67873 (change remove to have a PartialEq bound) - #67897 (Use `as_deref()` to replace `as_ref().map(...)`) - #67906 (Silence `TooGeneric` error) - #67912 (macros: typo fix) - #67915 (Use Self instead of $type) Failed merges: r? @ghost
djugei
commented
Jan 7, 2020
Contributor
thank you @varkor ! a lot of my work was blocked on this :) |
eddyb
reviewed
Jan 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
eddyb
commented
Jan 18, 2020
Contributor
This PR needs to be reverted, and the ICE be replaced by a real error.
But for |
varkor
commented
Jan 20, 2020
ContributorAuthor
#68388 should fix this mistake. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
Fixes#66962.
r? @eddyb