Skip to content

fire "non_camel_case_types" for associated types - #67936

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:assoc-type-bad-style
Jan 7, 2020
Merged

fire "non_camel_case_types" for associated types#67936
bors merged 1 commit into
rust-lang:masterfrom
euclio:assoc-type-bad-style

Conversation

@euclio

Copy link
Copy Markdown
Contributor

Fixes#67920.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2020
@Centril

Copy link
Copy Markdown
Contributor

r? @Centril@bors r+

@bors

bors commented Jan 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit a7727c5 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2020
@est31

est31 commented Jan 6, 2020

Copy link
Copy Markdown
Member

Thanks @euclio for the quick fix!

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 6, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 7, 2020
@JohnTitorJohnTitor mentioned this pull request Jan 7, 2020
bors added a commit that referenced this pull request Jan 7, 2020
Rollup of 13 pull requests
Successful merges:
- #67566 (Add an unstable conversion from thread ID to u64)
- #67671 (Account for `type X = impl Trait;` in lifetime suggestion)
- #67727 (Stabilise vec::remove_item)
- #67877 (Omit underscore constants from rustdoc)
- #67880 (Handle multiple error fix suggestions carefuly)
- #67898 (Improve hygiene of `newtype_index`)
- #67908 (rustdoc: HTML escape const values)
- #67909 (Fix ICE in const pretty printing and resolve FIXME)
- #67929 (Formatting an example for method Vec.retain)
- #67934 (Clean up E0178 explanation)
- #67936 (fire "non_camel_case_types" for associated types)
- #67943 (Missing module std in example.)
- #67962 (Update books)
Failed merges:
r? @ghost
@bors
bors merged commit a7727c5 into rust-lang:masterJan 7, 2020
@euclio
euclio deleted the assoc-type-bad-style branch January 7, 2020 13:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bad_style doesn't fire for associated types

6 participants

@euclio@rust-highfive@Centril@bors@est31@davidtwco