Skip to content

remove explicit strip-hidden pass from compiler doc generation - #68039

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:remove-strip-hidden
Jan 10, 2020
Merged

remove explicit strip-hidden pass from compiler doc generation#68039
bors merged 1 commit into
rust-lang:masterfrom
euclio:remove-strip-hidden

Conversation

@euclio

Copy link
Copy Markdown
Contributor

strip-hidden is now implied by --document-private-items with #67875, so there's no need to specify it anymore.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2020
@dtolnay

Copy link
Copy Markdown
Member

r? dtolnay
@bors r+

@bors

bors commented Jan 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8267807 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020
@dtolnay

Copy link
Copy Markdown
Member

Thanks! Good catch.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 10, 2020
remove explicit strip-hidden pass from compiler doc generation
`strip-hidden` is now implied by `--document-private-items` with rust-lang#67875, so there's no need to specify it anymore.
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
remove explicit strip-hidden pass from compiler doc generation
`strip-hidden` is now implied by `--document-private-items` with rust-lang#67875, so there's no need to specify it anymore.
@CentrilCentril mentioned this pull request Jan 10, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
remove explicit strip-hidden pass from compiler doc generation
`strip-hidden` is now implied by `--document-private-items` with rust-lang#67875, so there's no need to specify it anymore.
@CentrilCentril mentioned this pull request Jan 10, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 10, 2020
remove explicit strip-hidden pass from compiler doc generation
`strip-hidden` is now implied by `--document-private-items` with rust-lang#67875, so there's no need to specify it anymore.
@JohnTitorJohnTitor mentioned this pull request Jan 10, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 10, 2020
remove explicit strip-hidden pass from compiler doc generation
`strip-hidden` is now implied by `--document-private-items` with rust-lang#67875, so there's no need to specify it anymore.
@JohnTitorJohnTitor mentioned this pull request Jan 10, 2020
bors added a commit that referenced this pull request Jan 10, 2020
Rollup of 8 pull requests
Successful merges:
- #66045 (Add method Result::into_ok)
- #67258 (Introduce `X..`, `..X`, and `..=X` range patterns)
- #68014 (Unify output of "variant not found" errors)
- #68019 (Build compiletest with in-tree libtest)
- #68039 (remove explicit strip-hidden pass from compiler doc generation)
- #68050 (Canonicalize rustc_error imports)
- #68059 (Allow specifying LLVM args in target specifications)
- #68075 (rustbuild: Cleanup book generation)
Failed merges:
- #68089 (Unstabilize `Vec::remove_item`)
r? @ghost
@dtolnaydtolnay assigned dtolnay and unassigned nikomatsakisJan 10, 2020
@bors
bors merged commit 8267807 into rust-lang:masterJan 10, 2020
@euclio
euclio deleted the remove-strip-hidden branch January 10, 2020 23:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@euclio@rust-highfive@dtolnay@bors@nikomatsakis