Uh oh!
There was an error while loading. Please reload this page.
Specify units for test timeout environment variables - #68097
Merged
Conversation
rust-highfive
commented
Jan 10, 2020
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
shepmaster
left a comment
Member
There was a problem hiding this comment.
In the realm of being clear, instead of "Clarify test timeout evironment variables", let's say
Specify units for test timeout environment variables
(note typo fix as well)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shepmaster
commented
Jan 10, 2020
Member
Care to link to the appropriate place so we can verify you read the code correctly? 👼 |
MikailBag
commented
Jan 10, 2020
ContributorAuthor
Sure. Here is code that parses env vars: Line 95 in f795e8a |
shepmaster
commented
Jan 12, 2020
Member
Thanks! @bors r+ rollup |
bors
commented
Jan 12, 2020
Collaborator
📌 Commit 91e9531 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 12, 2020
Specify units for test timeout environment variables I think it is not obvious (I got it from reading libtest sources), so it is worth mentioning in docs.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 13, 2020
Specify units for test timeout environment variables I think it is not obvious (I got it from reading libtest sources), so it is worth mentioning in docs.
bors added a commit
that referenced
this pull request
Jan 13, 2020
Rollup of 8 pull requests Successful merges: - #67313 (Document more use cases of dataflow) - #67959 (rustdoc: improve stability mark arrows) - #68097 (Specify units for test timeout environment variables) - #68135 (restore some rustc_parse visibilities for rustfmt) - #68145 (Expose `context::CheckLintNameResult`) - #68156 (Fix crate paths in comments) - #68157 (Clean up E0186 explanation) - #68161 (Fix system call docs for time::Instant) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is not obvious (I got it from reading libtest sources), so it is worth mentioning in docs.