Skip to content

use winapi for non-stdlib Windows bindings - #68141

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:replace-bindings-with-winapi
Jan 15, 2020
Merged

use winapi for non-stdlib Windows bindings#68141
bors merged 1 commit into
rust-lang:masterfrom
euclio:replace-bindings-with-winapi

Conversation

@euclio

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2020
@Centril

Copy link
Copy Markdown
Contributor

r? @alexcrichton

let r = GetModuleHandleExW(
GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS,
current_dll_path as usize,
current_dll_path as usize as *mut _,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't functions be cast directly to a raw pointer?

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jan 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7b564c6 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 15, 2020
…, r=alexcrichton
use winapi for non-stdlib Windows bindings
@JohnTitorJohnTitor mentioned this pull request Jan 15, 2020
bors added a commit that referenced this pull request Jan 15, 2020
Rollup of 12 pull requests
Successful merges:
- #67784 (Reset Formatter flags on exit from pad_integral)
- #67914 (Don't run const propagation on items with inconsistent bounds)
- #68141 (use winapi for non-stdlib Windows bindings)
- #68211 (Add failing example for E0170 explanation)
- #68219 (Untangle ZST validation from integer validation and generalize it to all zsts)
- #68222 (Update the wasi-libc bundled with libstd)
- #68226 (Avoid calling tcx.hir().get() on CRATE_HIR_ID)
- #68227 (Update to a version of cmake with windows arm64 support)
- #68229 (Update iovec to a version with no winapi dependency)
- #68230 (Update libssh2-sys to a version that can build for aarch64-pc-windows…)
- #68231 (Better support for cross compilation on Windows.)
- #68233 (Update compiler_builtins with changes to fix 128 bit integer remainder for aarch64 windows.)
Failed merges:
r? @ghost
@bors
bors merged commit 7b564c6 into rust-lang:masterJan 15, 2020
@euclio
euclio deleted the replace-bindings-with-winapi branch January 15, 2020 17:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@euclio@rust-highfive@Centril@alexcrichton@bors@retep998@estebank