Uh oh!
There was an error while loading. Please reload this page.
Make extra::bigint sane - #6822
Closed
Aatch wants to merge 1 commit into
Closed
Conversation
brson
commented
May 30, 2013
Contributor
Nice find! 🌸 I wonder how much more we could get from removing other inline attributes. |
bors added a commit
that referenced
this pull request
May 30, 2013
This removes all the `#[inline(always)]` attributes from the bigint module, all 112 of them... This was responsible for increasing the code size of the module by almost 100x and accounts for roughly 95% of the previous build time of libextra.
bstrie
commented
May 30, 2013
Contributor
@Aatch I agree with this change, but this doesn't leave a single |
Aatch
commented
May 30, 2013
ContributorAuthor
@bstrie there has been talk of removing the module altogether. The motivation being that this has very few, if any, users. There are some functions that should probably be marked with |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 11, 2021
Rustfmt version "Two" changelog: none This enables some ~bug fixes~ changes from rustfmt. This is more consistent with rustc's config, and should be more forward-compatible. Also, the changes look good IMO. 😃
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6822: Read version of rustc that compiled proc macro r=edwin0cheng a=jsomedon Signed-off-by: Jay Somedon <jay.somedon@outlook.com> This PR is to fixrust-lang#6174. I basically * added two methods, `read_version` and `read_section`(used by `read_version`) * two new crates `snap` and `object` to be used by those two methods I just noticed that some part of code were auto-reformatted by rust-analyzer on file save. Does it matter? Co-authored-by: Jay Somedon <jay.somedon@outlook.com> Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
8716: Replace `memmap` with `memmap2` in `proc_macro_api` r=edwin0cheng a=memoryruins rust-lang#7522 did the same for `proc_macro_srv` before this usage of `memmap` was introduced to `proc_macro_api` in rust-lang#6822 . Something like [`cargo-deny`](https://github.com/EmbarkStudios/cargo-deny-action) could help prevent specific crates (and versions, licenses, etc) from being introduced into the crate tree, but that's unrelated to this pull request. Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all the
#[inline(always)]attributes from the bigint module, all 112 of them... This was responsible for increasing the code size of the module by almost 100x and accounts for roughly 95% of the previous build time of libextra.