Uh oh!
There was an error while loading. Please reload this page.
remove redundant clones, found by clippy - #68252
Merged
Merged
Conversation
oli-obk
commented
Jan 15, 2020
Contributor
bors
commented
Jan 15, 2020
Collaborator
📌 Commit 312c3a0 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 15, 2020
…i-obk remove redundant clones, found by clippy
bors added a commit
that referenced
this pull request
Jan 15, 2020
Rollup of 6 pull requests Successful merges: - #68123 (Implement Cursor for linked lists. (RFC 2570).) - #68212 (Suggest to shorten temporary lifetime during method call inside generator) - #68232 (Optimize size/speed of Unicode datasets) - #68236 (Add some regression tests) - #68237 (Account for `Path`s in `is_suggestable_infer_ty`) - #68252 (remove redundant clones, found by clippy) Failed merges: r? @ghost
eddyb
commented
Jan 16, 2020
Contributor
This reminds me, are we linting |
sinkuu
commented
Jan 16, 2020
Contributor
There's clone_on_copy lint. |
eddyb
commented
Jan 16, 2020
Contributor
Yeah, but are we enabling it on |
matthiaskrgr
commented
Jan 16, 2020
MemberAuthor
None of the clippy lints are run on rustc code by "default", but you can get clippy defaults run with Meanwhile I've prepared a PR here: #68292 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.